orchestrator-core icon indicating copy to clipboard operation
orchestrator-core copied to clipboard

Remove pydantic_forms.types imports

Open Mark90 opened this issue 2 years ago • 1 comments

In #308 the pydantic-forms library was added as a dependency, and form types in orchestrator-core were removed. To remain backwards compatible we import most of pydantic_forms.types in orchestrator.types.

These imports should be removed, and a migration script should be added to rewrite the imports in orchestrator implementations. For this script one can take a look at the migrate_pydantic_2x.py script which performs similar rewrite actions.

Tasks

  • [ ] Remove pydantic_forms imports in orchestrator.forms that are not used in core
  • [ ] Add a migration script for orchestrator implementors

Mark90 avatar Dec 14 '23 15:12 Mark90

This should be deprecated and removed in release 2.1.*

pboers1988 avatar Jan 17 '24 13:01 pboers1988

This should not be a lot of work and saves some confusion when looking for where these form types are defined. (ran into this myself the other day)

Mark90 avatar Feb 07 '25 16:02 Mark90

https://git.ia.surfsara.nl/netdev/automation/projects/orchestrator/-/issues/2251

Mark90 avatar Feb 07 '25 16:02 Mark90