Workbench icon indicating copy to clipboard operation
Workbench copied to clipboard

Library: Port 'View Switcher' to Python

Open UrtsiSantsi opened this issue 1 year ago • 2 comments

UrtsiSantsi avatar Oct 30 '23 03:10 UrtsiSantsi

Some observations:

  1. This demo opens a window even for JavaScript, but the Python window size is different. Vala has the same size as Python.
  2. For me the Python preview never starts the first time I press 'Run' (it gives me some errors), only the second for all demos. Then it works as expected. Vala and Rust start don't have such problems. For this demo however I get: image then it works, but the window can't be closed. Vala preview can be closed normally.

UrtsiSantsi avatar Oct 30 '23 03:10 UrtsiSantsi

@theCapypara I suggest using a .get_ancestor method on the button as button is contained inside row. See https://github.com/workbenchdev/demos/pull/109#issuecomment-1962976016 This would ensure we aren't creating a reference to row in a python object

imhemish avatar Feb 25 '24 16:02 imhemish

HJo I just realized this one is still opened against Workbench.

Ok I'll close this one instead. Sorry for the noise

sonnyp avatar Feb 29 '24 14:02 sonnyp