WordPress Fan

Results 34 comments of WordPress Fan

@MathieuLamiot u mean use multiply by not divided by, correct? I played with this also but Yes we may need to change the threshold also.

all sizes are available in dev tools: ![Screenshot from 2024-05-14 13-23-30](https://github.com/wp-media/wp-rocket/assets/146129302/4fb2ad68-ac03-44b4-8f2f-3ec902d96c65) We only need to know which ones we need to support and which we don't, because even with the...

I really like using `DOMDocument` but, In the past we used `DOMDocument` and that was not the best approach and from performance wise it takes more time than regex. I...

as a final decision, we need to exclude the following urls: ``` https://domain.ext/file.php?url=img.jpg https://domain.ext/file.js?url=img.jpg https://domain.ext/file.php#url=img.jpg chrome-extension://extension-hash/path/to/image/x.svg linear-gradient(160deg, rgb(255, 255, 255) 0%, rgb(248, 246, 243) 100%) ``` Correct?

I was thinking of doing that from the php side, exactly here: https://github.com/wp-media/wp-rocket/blob/715e19cf5eb38fa51ae566422015b74d947f55b5/inc/Engine/Media/AboveTheFold/AJAX/Controller.php#L53 not from the JS side @Khadreal

@wp-media/engineering-plugin-team I created this PR https://github.com/wp-media/wp-rocket/pull/6605 to validate the idea and seems like it's working and covering many cases, can u plz take a look and once the idea is...

Done, now we have a filter to validate the image src

you can completely disable our compatibility with CF7 using the following code: ``` add_filter( 'rocket_thirdparty_load', function( $status, $thirdparty ) { if ( 'contact-form-7' !== $thirdparty ) { return $status; }...

I tried to reproduce the issue 3 times but still can't see it: ![image](https://github.com/wp-media/wp-rocket/assets/146129302/ec05c5db-1dd4-447d-a7d8-44a36cd03e9c) I'm using https://e2e.rocketlabsqa.ovh/ as a live site. @Mai-Saad do u still see this issue?

> Transifex automatic translations are rarely accurate at the first shot and still need to be reviewed by a human, especially for our features' names. Sorry for the late reply...