release-toolkit icon indicating copy to clipboard operation
release-toolkit copied to clipboard

Add RtL support for draw_text_attachment_to_canvas

Open momo-ozawa opened this issue 3 years ago • 0 comments

Description

Text alignment for screenshot overlay text must be flipped for RtL languages.

Background Context

Ref: https://github.com/wordpress-mobile/WordPress-iOS/pull/16707

While adding the ar-SA (Arabic) and he (Hebrew) locales to screenshot generation, I realized that the overlay text alignment needs to to be flipped for RtL languages.

In the Jetpack app, the splash image has text that's left-aligned for LtR languages, which needs to be flipped to be right-aligned for RtL languages.

JP

iPhone XS Max-0-Splash iPhone XS Max-1-MySite iPhone XS Max-2-ActivityLog iPhone XS Max-3-JetpackScan iPhone XS Max-4-JetpackBackup iPhone XS Max-5-Stats

momo-ozawa avatar Jun 22 '21 01:06 momo-ozawa