gutenberg-mobile icon indicating copy to clipboard operation
gutenberg-mobile copied to clipboard

Include Block experiments classname package

Open geriux opened this issue 9 months ago • 1 comments

Related PR:

  • https://github.com/WordPress/gutenberg/pull/61616

This PR adds a new step to install dependencies of the block-experiments submodule. Currently, we were relying on Gutenberg to have all needed dependencies for this submodule, but since the recent removal of the classnames package, it makes sense this submodule also installs its dependencies as we do it for Jetpack and Gutenberg.

It adds a new bash file to install the block-experiments dependencies, which will be called in the postinstall script in Gutenberg Mobile's package.json

A new item was added to Metro's block list, to not include files from the @wordpress package from its dependencies, the reason for this is to solve problems with bringing old references of older versions of the native files. This shouldn't affect anything as we are loading these packages from Gutenberg already.

To test CI checks should pass.

PR submission checklist:

  • [x] I have considered adding unit tests where possible.
  • [x] I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

geriux avatar May 13 '24 15:05 geriux

Will wait for this item to be resolved before reviewing. Feel free to re-request after it's been resolved. Thanks!

Done! I decided to not unify both just in case separate configurations are preferred for each submodule 👍

geriux avatar May 14 '24 15:05 geriux

Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.

geriux avatar May 16 '24 09:05 geriux

Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.

Ah! My bad on that. 😬

twstokes avatar May 16 '24 16:05 twstokes