gutenberg-mobile icon indicating copy to clipboard operation
gutenberg-mobile copied to clipboard

Published 20 hours ago • verified publisher icon wordpress-mobile

Issue/3800 unitcontrol label color

Open AmandaRiu opened this issue 4 years ago • 10 comments

Fixes: #https://github.com/wordpress-mobile/gutenberg-mobile/issues/3800 Gutenberg PR: https://github.com/WordPress/gutenberg/pull/34057

To test

Follow the test instructions in the Gutenberg PR: https://github.com/WordPress/gutenberg/pull/34057

PR submission checklist:

  • [x] I have considered adding unit tests where possible.
  • [x] I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

AmandaRiu avatar Aug 12 '21 22:08 AmandaRiu

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

peril-wordpress-mobile[bot] avatar Aug 12 '21 22:08 peril-wordpress-mobile[bot]

@AmandaRiu I see that this PR was assigned to 1.58.3 milestone but that was created for a hotfix, if you're aiming to include this in the next release we would need to create the 1.60.1 milestone.

fluiddot avatar Aug 17 '21 11:08 fluiddot

@AmandaRiu I see that this PR was assigned to 1.58.3 milestone but that was created for a hotfix, if you're aiming to include this in the next release we would need to create the 1.60.1 milestone.

Thanks @fluiddot , yup, I meant this for the next release. I've moved it.

AmandaRiu avatar Aug 17 '21 14:08 AmandaRiu

Hey @AmandaRiu. We will cut the 1.60.0 release today. I will bump this PR to the next milestone, but please let me know if you’d rather us work to include this PR in 1.60.0. Thanks!

geriux avatar Aug 19 '21 08:08 geriux

Hey @AmandaRiu. :wave: :smile: We will cut the 1.61.0 release today. I will bump this PR to the next milestone, but please let me know if you’d rather us work to include this PR in 1.61.0. Thanks!

Edit: There is a chance the release cut will be delayed until tomorrow. Since this PR is still awaiting the :heavy_check_mark: , I've bumped the milestone - but let me know if you'd like to get it into 1.61.0. :+1:

mkevins avatar Sep 02 '21 01:09 mkevins

Thanks @mkevins! I'll be taking over this PR. Bumping the milestone is fine I think 👍

guarani avatar Sep 02 '21 02:09 guarani

Hey @AmandaRiu .We will cut the 1.62.0 release today so I am bumping this PR to the next milestone. Let me know if you’d rather us work to include this PR in 1.62.0. Thanks!

jd-alexander avatar Sep 17 '21 15:09 jd-alexander

Thanks @jd-alexander! I've taken over this PR and for now I'm going to remove the milestone now though, and re-add it once it's ready. I'd hoped to get to it sooner 😞.

guarani avatar Sep 17 '21 20:09 guarani

Thanks @jd-alexander! I've taken over this PR and for now I'm going to remove the milestone now though, and re-add it once it's ready. I'd hoped to get to it sooner 😞.

No problem @guarani Thanks for the update!

jd-alexander avatar Sep 17 '21 20:09 jd-alexander

👋 I wasn't able to get to this unfortunately, I'd meant to take over as PR author. Apologies for the long delay. I'll un-assign myself as reviewer and leave this open for someone else to get to if needed. cc @hypest

guarani avatar Mar 28 '22 13:03 guarani

Wow, this has been open for a very long time and the linked PR was already closed two years ago due to being stale. I'm going to go ahead and close this one. It can be reopened in the future if needed.

AmandaRiu avatar Feb 14 '24 17:02 AmandaRiu