gutenberg-mobile icon indicating copy to clipboard operation
gutenberg-mobile copied to clipboard

[WIP] Contact Info block integration test

Open fluiddot opened this issue 4 years ago • 3 comments
trafficstars

Related to issue: https://github.com/wordpress-mobile/gutenberg-mobile/issues/3673

This PR adds an integration test for the Contact Info block (Jetpack).

Additionally, it updates the Jest configuration to able the integration tests:

  • Add test helper to the module name mapper.
  • Fixes transpiled packages calculation.

PR submission checklist:

  • [ ] I have considered adding unit tests where possible.
  • [ ] I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

fluiddot avatar Jun 25 '21 14:06 fluiddot

@guarani @illusaen I was investigating how to include integration tests in Gutenberg Mobile and I realized that it was surprisingly easy 😄.

As an example, I added a test case for the Contact Info block, feel free to take over this PR if you want to finish the work.

fluiddot avatar Jun 25 '21 14:06 fluiddot

I ran the test and it's working great. I'm not sure if this is still a draft because the test should be fleshed out a bit more, but leaving an approval in-case you want to merge as-is.

Thanks @guarani for the review ❤️ ! I left it in draft because we might want to add more test cases for the Contact info block, I hope to spare some time next week for this, extend the test and merge it.

fluiddot avatar Jul 02 '21 07:07 fluiddot

I want to mention this proposal I just created, https://github.com/wordpress-mobile/gutenberg-mobile/issues/3942. In short, if we could add integration tests inside the Jetpack repo itself, there might be some wins in terms of code coverage tool compatibility and keeping app code and tests close together.

guarani avatar Sep 09 '21 15:09 guarani