WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Notifications: comments no longer support pre-formatted text

Open rickybanister opened this issue 9 years ago • 7 comments

Current stable version of the app (supports pre-formatted text): screen shot 2015-06-26 at 9 56 09 am

Current beta version (displaying merriweather only): screen shot 2015-06-26 at 9 57 19 am

rickybanister avatar Jun 26 '15 13:06 rickybanister

I tested a comment with preformatted text (using <pre> tags), and the notification used the correct formatting in terms of line breaks and spaces. The only issue I saw was the font, which used the regular font instead of a monospace font.

Since the only issue is the font used for pre-formatted text, I'm going to mark this issue as low-priority. Please update if this is causing any other issues for you.

rachelmcr avatar Nov 12 '15 14:11 rachelmcr

This is still an issue; a couple notes:

  • This matches the current behavior for <pre> tags in comments in Calypso web (web notifications display those preformatted comments without additional styling)
  • Based on timing and behavior, the change happened in this commit where we switched to using Merriweather in notifications comment detail.

rachelmcr avatar May 16 '16 10:05 rachelmcr

Let's look at this when we investigate making the switch away from Merriweather.

mattmiklic avatar Feb 13 '17 18:02 mattmiklic

Can confirm this is still an issue after the switch to Noto. Testing the 7.1 beta, this:

before

becomes this:

after

It looks like the font declaration is just overriding everything, and we need to specify Courier for pre and a monospace font (Menlo?) for code.

mattmiklic avatar Mar 06 '17 21:03 mattmiklic

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

stale[bot] avatar Apr 08 '20 20:04 stale[bot]

This seems to still be an issue.

aerych avatar Apr 14 '21 16:04 aerych

The comment formatting in Notification Details has improved, but it still doesn't match with the formatting in the Comments list screen. So, while the initial issue is resolved, I believe the expected behavior is for the formatting in Notification Details to match that of the Comments screen.

Notifications Details Comments List

salimbraksa avatar Mar 08 '24 13:03 salimbraksa