Fixing/Implementing quality of life improvements to Issue #24206

[matthewsun04]

Modifications following issues raised by #24207.

To test:

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• [ ] I have completed the Regression Notes.
• [ ] I have considered adding unit tests for my changes.
• [ ] I have considered adding accessibility improvements for my changes.
• [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• [ ] WordPress.com sites and self-hosted Jetpack sites.
• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] VoiceOver.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] iPhone and iPad.
• [ ] Multi-tasking: Split view and Slide over. (iPad)

[sonarqubecloud[bot]]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[crazytonyli]

Thanks for the changes! It'll be okay to merge this PR once the conflicts are resolved.

[kean]

Hey,

Modifications following issues raised by https://github.com/wordpress-mobile/WordPress-iOS/pull/24207.

Could you please elaborate on what issues it's referring to? The linked PR doesn't seem to contain any related changes.

shortVersionString

This method has some additional logic for DEBUG mode on top of just reading CFBundleShortVersionString. I don't think we should continue to use it, and it can't simply replaced the code that reads CFBundleShortVersionString as it's not fully equivalent.