WordPress-iOS
WordPress-iOS copied to clipboard
Move `ImmuTable` to dedicated package
I was looking around the codebase and saw what looked like a quick win for modularization: move the ImmuTable implementation in a dedicated package.
This is just a little step forward towards more modularization and less time spend compiling.
WordPressUI could have been another destination for the logic. If you feel it's better to move it there, I'll follow up with a dedicated PR. The bulk of the work was to move it out of the main target anyway
To test:
Regression Notes
-
Potential unintended areas of impact
-
What I did to test those areas of impact (or what existing automated tests I relied on)
-
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
| 2 Warnings | |
|---|---|
| :warning: | Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve). |
| :warning: | This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
| 1 Message | |
|---|---|
| :book: | This PR is still a Draft: some checks will be skipped. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24152-d4441a7 | |
| Version | 25.7.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | d4441a77af28be9160a31634343d00f8d58b007d | |
| App Center Build | WPiOS - One-Offs #11588 |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24152-d4441a7 | |
| Version | 25.7.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | d4441a77af28be9160a31634343d00f8d58b007d | |
| App Center Build | jetpack-installable-builds #10618 |
FYI @kean @crazytonyli I started this when first looking into this round of modularization but then paused it for the Core Data stuff. I don't consider it urgent but wanted to let you know about it in case you end up touching the ImmuTable- pieces.
Oh looks like I removed some of the code that was using it. We don't really use this type anymore. For forms, we stick with SwiftUI.
Oh looks like I removed some of the code that was using it. Excellent
For forms, we stick with SwiftUI. This is the way
I'll see whether to continue with this or drop once done with #24165
I'm going to close this PR as we've wrapped up the modularization effort and it also seems too far behind trunk now.