WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Move `ImmuTable` to dedicated package

Open mokagio opened this issue 9 months ago • 7 comments

I was looking around the codebase and saw what looked like a quick win for modularization: move the ImmuTable implementation in a dedicated package.

This is just a little step forward towards more modularization and less time spend compiling.

WordPressUI could have been another destination for the logic. If you feel it's better to move it there, I'll follow up with a dedicated PR. The bulk of the work was to move it out of the main target anyway

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

mokagio avatar Mar 06 '25 00:03 mokagio

2 Warnings
:warning: Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
:book: This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

dangermattic avatar Mar 06 '25 00:03 dangermattic

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24152-d4441a7
Version25.7.1
Bundle IDorg.wordpress.alpha
Commitd4441a77af28be9160a31634343d00f8d58b007d
App Center BuildWPiOS - One-Offs #11588
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Mar 06 '25 01:03 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24152-d4441a7
Version25.7.1
Bundle IDcom.jetpack.alpha
Commitd4441a77af28be9160a31634343d00f8d58b007d
App Center Buildjetpack-installable-builds #10618
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Mar 06 '25 01:03 wpmobilebot

FYI @kean @crazytonyli I started this when first looking into this round of modularization but then paused it for the Core Data stuff. I don't consider it urgent but wanted to let you know about it in case you end up touching the ImmuTable- pieces.

mokagio avatar Mar 11 '25 08:03 mokagio

Oh looks like I removed some of the code that was using it. We don't really use this type anymore. For forms, we stick with SwiftUI.

kean avatar Mar 11 '25 13:03 kean

Oh looks like I removed some of the code that was using it. Excellent

For forms, we stick with SwiftUI. This is the way

mokagio avatar Mar 12 '25 00:03 mokagio

I'll see whether to continue with this or drop once done with #24165

mokagio avatar Mar 12 '25 00:03 mokagio

I'm going to close this PR as we've wrapped up the modularization effort and it also seems too far behind trunk now.

kean avatar Aug 25 '25 21:08 kean