WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard
verified publisher icon wordpress-mobile

Fix issue in signing into another WP.com account

Open crazytonyli opened this issue 1 year ago • 4 comments

This PR is built on top of https://github.com/wordpress-mobile/WordPress-iOS/pull/23644.

This PR fixes an issue with having multiple WP.com accounts in the app. Here are steps to reproduce the issue.

  1. Create a self-hosted site and connect it to WP.com account A.
  2. Open Jetpack app and sign in using WP.com account B.
  3. Add the self-hosted site in step 1.
  4. Tap "Stats" of the self-hosted site. You'll see a "Log in" button here.
  5. Tap the Log in button to sign in with WP.com account A.

Expected behaviour: the app displays Stats content after successful login.

Actual behaviour: the app is kind of messed up, because it incorrectly saves the second WP.com account as the default account.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

crazytonyli avatar Oct 02 '24 09:10 crazytonyli

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23654-82fd302
Version25.4
Bundle IDcom.jetpack.alpha
Commit82fd302767bf4fa8c6119a847103661505209890
App Center Buildjetpack-installable-builds #9875
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Oct 02 '24 10:10 wpmobilebot

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23654-82fd302
Version25.4
Bundle IDorg.wordpress.alpha
Commit82fd302767bf4fa8c6119a847103661505209890
App Center BuildWPiOS - One-Offs #10833
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Oct 02 '24 10:10 wpmobilebot

@kean @jkmassel Shall we decide if we should fix this issue (see the PR description)?

crazytonyli avatar Oct 18 '24 06:10 crazytonyli

You should not be able to log in with a second wp.com account without any way to manage it, so I suggest closing this loophole and throwing an error if this happens.

kean avatar Oct 18 '24 19:10 kean

I have chatted with Jeremy on Slack. And he agreed that we should stop allowing signing in with another WP.com account until there is multi-account support at the app UI level. So, I'll close this PR and open another one.

crazytonyli avatar Oct 22 '24 00:10 crazytonyli