WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Simplify Color APIs

Open jkmassel opened this issue 1 year ago • 2 comments

As discussed, the color APIs are sort of all over the place. Let's make them simpler and easier to maintain.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

jkmassel avatar Aug 29 '24 05:08 jkmassel

3 Warnings
:warning: Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

dangermattic avatar Aug 29 '24 05:08 dangermattic

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23528-f01f1d6
Version25.3
Bundle IDorg.wordpress.alpha
Commitf01f1d6ad1089490f6d7ee43ea926f609ffa67e8
App Center BuildWPiOS - One-Offs #10593
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Aug 29 '24 05:08 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23528-f01f1d6
Version25.3
Bundle IDcom.jetpack.alpha
Commitf01f1d6ad1089490f6d7ee43ea926f609ffa67e8
App Center Buildjetpack-installable-builds #9635
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Sep 04 '24 00:09 wpmobilebot

@kean – I've moved everything over to AppColor – I think the rest can be addressed separately?

jkmassel avatar Sep 04 '24 16:09 jkmassel