WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Sidebar: Notifications

Open kean opened this issue 1 year ago • 2 comments

  • Add "Notifications" navigation item to the new Home page as a shortcut to quickly access your notifications and see if you have any new ones
  • Implement notifications badge when you have new notifications
Screenshot 2024-08-27 at 12 40 11 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

kean avatar Aug 27 '24 17:08 kean

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23519-f5bee88
Version25.3
Bundle IDorg.wordpress.alpha
Commitf5bee8816f8efb7a95dd3ed23bd3efccb25c2d7d
App Center BuildWPiOS - One-Offs #10557
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Aug 27 '24 17:08 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23519-f5bee88
Version25.3
Bundle IDcom.jetpack.alpha
Commitf5bee8816f8efb7a95dd3ed23bd3efccb25c2d7d
App Center Buildjetpack-installable-builds #9598
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Aug 27 '24 17:08 wpmobilebot

If I invoke the popover then rotate the iPad, the placement is odd

I added it to my backlog for this project

In the context of a specific site, if I tap the "Notifications" icon I'd expect to see notifications for just that site. Probably a future improvement.

I had a similar thought, but I agree that it's not in the scope of the project. The same potentially applies to the Reader.

kean avatar Aug 29 '24 23:08 kean

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Sep 09 '24 06:09 sentry[bot]