WordPress-iOS
WordPress-iOS copied to clipboard
Sidebar: Notifications
- Add "Notifications" navigation item to the new Home page as a shortcut to quickly access your notifications and see if you have any new ones
- Implement notifications badge when you have new notifications
To test:
Regression Notes
-
Potential unintended areas of impact
-
What I did to test those areas of impact (or what existing automated tests I relied on)
-
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23519-f5bee88 | |
| Version | 25.3 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f5bee8816f8efb7a95dd3ed23bd3efccb25c2d7d | |
| App Center Build | WPiOS - One-Offs #10557 |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23519-f5bee88 | |
| Version | 25.3 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f5bee8816f8efb7a95dd3ed23bd3efccb25c2d7d | |
| App Center Build | jetpack-installable-builds #9598 |
If I invoke the popover then rotate the iPad, the placement is odd
I added it to my backlog for this project
In the context of a specific site, if I tap the "Notifications" icon I'd expect to see notifications for just that site. Probably a future improvement.
I had a similar thought, but I agree that it's not in the scope of the project. The same potentially applies to the Reader.
Suspect Issues
This pull request was deployed and Sentry observed the following issues:
- ‼️ EXC_BREAKPOINT: refresh
valueView Issue
Did you find this useful? React with a 👍 or 👎