WordPress-iOS
WordPress-iOS copied to clipboard
Move more pods to SPM
- Install MediaEditor
- Cleanup CocoaPods (details in the comments) – this is another small improvement in app size, down from 113.6 MB to 113.1 MB (-0.5 MB)
- Prepare Gravatar and FSInteractiveMap using SPM, but it needs a bit more work – not included in this PR
Related PRs:
- https://github.com/wordpress-mobile/MediaEditor-iOS/pull/45
- https://github.com/wordpress-mobile/MediaEditor-iOS/pull/46
To test:
- Verify that the media editor doesn't crash and displays its custom icons
Regression Notes
-
Potential unintended areas of impact
-
What I did to test those areas of impact (or what existing automated tests I relied on)
-
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23395-9ffd18c | |
| Version | 25.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9ffd18c1b8afe95986c177632689a0f73fc15e80 | |
| App Center Build | WPiOS - One-Offs #10248 |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23395-9ffd18c | |
| Version | 25.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9ffd18c1b8afe95986c177632689a0f73fc15e80 | |
| App Center Build | jetpack-installable-builds #9296 |
| 1 Warning | |
|---|---|
| :warning: | View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity. |
Generated by :no_entry_sign: Danger