WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Remove direct wpxmlrpc usages from the app

Open kean opened this issue 1 year ago • 2 comments

The wpxmlrpc was another transient dependency declared in WordPressKit.podspec but used directly from the app. WordPressKit now re-export the only property from wpxmlrpc that was used by the app.

If we end up using Xcode targets to define WordPressKit, we'll include it as a Swift package and link it statically in WordPressKit. Either way, it's one less dependency to worry about.

To test:

Just to make sure it works, I span a local WP instance and changes a password:

Not sure what's up with "Updating..." in the background. I left a note to check it later.

Screenshot 2024-06-26 at 3 26 50 PM

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

kean avatar Jun 26 '24 19:06 kean

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23389-3268f16
Version25.1
Bundle IDorg.wordpress.alpha
Commit3268f1679ad209e9b1f94b492ad77f7e5e6d6830
App Center BuildWPiOS - One-Offs #10270
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Jun 26 '24 19:06 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23389-3268f16
Version25.1
Bundle IDcom.jetpack.alpha
Commit3268f1679ad209e9b1f94b492ad77f7e5e6d6830
App Center Buildjetpack-installable-builds #9317
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Jun 26 '24 19:06 wpmobilebot

1 Warning
:warning: Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.

Generated by :no_entry_sign: Danger

dangermattic avatar Jul 05 '24 22:07 dangermattic