WordPress-iOS
WordPress-iOS copied to clipboard
Rename Subscribers notification details header
Fixes https://github.com/Automattic/wordpress-mobile/issues/61
It's the final part of the Subscribers Details screen redesign. The problem is that every notification response contains a "title" property that is applied to a notification details screen's title. I made this little workaround to rename Followers to Subscribers without touching the backend.
To test:
- [ ] Prepare a notification about new subscribers
- [ ] Go to the screen and compare it with the designs
- [ ] Make sure you can see the redesigned name of the feature "Followers" -> "Subscribers."
Regression Notes
-
Potential unintended areas of impact Notifications details
-
What I did to test those areas of impact (or what existing automated tests I relied on) Manual tests
-
What automated tests I added (or what prevented me from doing so) Legacy code
PR submission checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23337-336d12a | |
| Version | 24.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 336d12ad0401a0e7c61ede8e25d56959829d68fd | |
| App Center Build | WPiOS - One-Offs #10135 |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23337-336d12a | |
| Version | 24.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 336d12ad0401a0e7c61ede8e25d56959829d68fd | |
| App Center Build | jetpack-installable-builds #9183 |