WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

In-App Updates: Prompt update after phased release is complete

Open momo-ozawa opened this issue 9 months ago • 2 comments

Part of https://github.com/Automattic/wordpress-mobile/issues/55 Part of https://github.com/Automattic/wordpress-mobile/issues/56

Description

  • Adds a check to only show the update prompts if it's been 7 days since the latest version was released (i.e. phased release is at 100%), to prevent showing the prompt to users who have automatic updated enabled.

How to test

Flexible update

Preconditions

  • In Xcode, change the app version to something lower than the current app store version, e.g. 24.6
  • Enable the In-App Updates remote feature flag

Test 1.1

  • Run on a real device
  • ✅ Verify the flexible update is NOT displayed

Test 1.2

  • Change delayInDays default value to 1
  • Run on a real device
  • ✅ Verify the flexible update is displayed

Blocking update

Preconditions

  • In Xcode, change the app version to something lower than the current app store version, e.g. 24.6
  • Enable the In-App Updates remote feature flag
  • Change the In-App Update Blocking Version remote config value to 24.7

Test 2.1

  • Run on a real device
  • ✅ Verify the blocking update is NOT displayed

Test 2.2

  • Change delayInDays default value to 1
  • Run on a real device
  • ✅ Verify the blocking update is displayed

Regression Notes

  1. Potential unintended areas of impact Showing app update prompt

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Added unit test

  3. What automated tests I added (or what prevented me from doing so) AppUpdateCoordinatorTests

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

momo-ozawa avatar May 16 '24 13:05 momo-ozawa