WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Enable performance monitoring

Open wzieba opened this issue 1 year ago β€’ 2 comments

This PR enables Performance Monitoring in the app.

To test:

  1. Open WPCrashLoggingProvider
  2. Update sampler to { 1.0 } and profilingRate to 1.0
  3. Run the app in Release variant
  4. Verify that in Sentry Performance and Profiling tabs there are new reports generated by your device.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

wzieba avatar May 14 '24 10:05 wzieba

Jetpack AlphaπŸ“² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23201-829130c
Version24.9
Bundle IDcom.jetpack.alpha
Commit829130c91a32c19c2f90231a2a36aa00d6247e34
App Center Buildjetpack-installable-builds #8944
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 14 '24 10:05 wpmobilebot

WordPress AlphaπŸ“² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23201-829130c
Version24.9
Bundle IDorg.wordpress.alpha
Commit829130c91a32c19c2f90231a2a36aa00d6247e34
App Center BuildWPiOS - One-Offs #9895
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 14 '24 10:05 wpmobilebot

@mokagio hi Gio! Friendly ping in case you missed this PR - do you think we could merge it this or next week? πŸ™‚

wzieba avatar May 22 '24 14:05 wzieba

πŸ‘‹ I bumped the milestone because this doesn't seem like a blocker for the 25.0 release cut today.

guarani avatar May 27 '24 15:05 guarani

Thanks @mokagio !

wzieba avatar May 28 '24 07:05 wzieba

I've been getting some odd crashes in SentryTracer in startDeadlineTimer when debugging, which might be related to this change. @mokagio wdyt about disabling it for now just to be safe unless there is a need for this feature? I think we should be a bit more reserved in terms of what tracking features are enabled.

kean avatar Jun 13 '24 17:06 kean

Addressed in #23372

wzieba avatar Jun 19 '24 13:06 wzieba

Hey, thanks @wzieba. The team agreed to disable it for now to reduce the risk in the upcoming releases. I took care of it in https://github.com/wordpress-mobile/WordPress-iOS/pull/23372 and it was already merged back in trunk.

kean avatar Jun 19 '24 14:06 kean