Enable performance monitoring
This PR enables Performance Monitoring in the app.
To test:
- Open
WPCrashLoggingProvider - Update
samplerto{ 1.0 }andprofilingRateto1.0 - Run the app in Release variant
- Verify that in Sentry Performance and Profiling tabs there are new reports generated by your device.
Regression Notes
-
Potential unintended areas of impact
-
What I did to test those areas of impact (or what existing automated tests I relied on)
-
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isnβt complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
π² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23201-829130c | |
| Version | 24.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 829130c91a32c19c2f90231a2a36aa00d6247e34 | |
| App Center Build | jetpack-installable-builds #8944 |
π² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23201-829130c | |
| Version | 24.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 829130c91a32c19c2f90231a2a36aa00d6247e34 | |
| App Center Build | WPiOS - One-Offs #9895 |
@mokagio hi Gio! Friendly ping in case you missed this PR - do you think we could merge it this or next week? π
π I bumped the milestone because this doesn't seem like a blocker for the 25.0 release cut today.
Thanks @mokagio !
I've been getting some odd crashes in SentryTracer in startDeadlineTimer when debugging, which might be related to this change. @mokagio wdyt about disabling it for now just to be safe unless there is a need for this feature? I think we should be a bit more reserved in terms of what tracking features are enabled.
Addressed in #23372
Hey, thanks @wzieba. The team agreed to disable it for now to reduce the risk in the upcoming releases. I took care of it in https://github.com/wordpress-mobile/WordPress-iOS/pull/23372 and it was already merged back in trunk.