WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

[Notifications Refresh] Redesign Likes and Follows details content

Open justtwago opened this issue 9 months ago • 3 comments

Fixes https://github.com/Automattic/wordpress-mobile/issues/17

The PR contains refreshed designs for Likes and Followers notifications content.

Please, note that there are no designs for Followers in Figma, so I reused the same design for Likes and moved an original "Subscribe/Unsubscribe" inline action button to the right corner as suggested here: p1714157934304609-slack-C06BWNSR02K.

One more thing I noticed was a bug related to the inline action buttons. After going to the user's blog, subscribing/unsubscribing it from the blog page, and returning to the notification details, the inline action button doesn't change its state. Overall, the subscribe status is unpredictable and buggy, but I believe these bugs have to be resolved in a separate PR and are out of scope.

Followers Likes

To test:

  • [ ] Prepare an account with likes and follows notifications
  • [ ] Go to a "Followers" notification details and make sure that the list of followers' design matches to the Likes list.
  • [ ] Ensure that the inline action buttons work as usual
  • [ ] Go to a "Likes" notification details and match it to the designs

Regression Notes

  1. Potential unintended areas of impact Other notification details

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Manual tests

  3. What automated tests I added (or what prevented me from doing so) I couldn't add tests to the legacy code

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

justtwago avatar May 09 '24 17:05 justtwago

1 Warning
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

dangermattic avatar May 09 '24 17:05 dangermattic

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23178-1d6b5eb
Version24.8
Bundle IDorg.wordpress.alpha
Commit1d6b5eb9c80108286dd897d36738568669204664
App Center BuildWPiOS - One-Offs #9921
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 09 '24 17:05 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23178-1d6b5eb
Version24.8
Bundle IDcom.jetpack.alpha
Commit1d6b5eb9c80108286dd897d36738568669204664
App Center Buildjetpack-installable-builds #8970
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 09 '24 17:05 wpmobilebot