WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

[Hack Week] Post success view

Open kean opened this issue 1 year ago • 5 comments

Fixes #https://github.com/wordpress-mobile/WordPress-iOS/issues/21509.

I've been going through the maintenance board, noticed the linked defect, and decided to resurrect this PR from the last Hack Week, which I didn't get to complete then. The new screen looks more like what you see in Gutenberg, and has a new "Promote with Blaze" button.

The initial idea was to show this automatically as part of the Prepublishing sheet, but this is a more conservative approach that simply replaced the current screen (with a slightly broken layout).

The design comes from one of the prototypes made with Chris, but with some minor changes. There've been so many versions of this, I don't any particular direction was picked as the final one in the end.

To test:

  • Publish a new post
  • Tap "View" on a snackbar
  • ✅ Verify that the updated success screen is shown
  • ✅ Verify that all buttons are working
  • ✅ Verify that for Blaze-enabled blogs, "Promote with Blaze" button is visible.

Regression Notes

  1. Potential unintended areas of impact: Post Publish Success Notice View
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

kean avatar Apr 30 '24 19:04 kean

1 Warning
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

dangermattic avatar Apr 30 '24 19:04 dangermattic

Hey, I updated the design based on what we discussed.

Screenshot 2024-05-01 at 11 23 42 AM

kean avatar May 01 '24 15:05 kean

LGTM! Did you figure out the Podfile.lock issue?

Looks like it got updated in trunk. The change disappear after the rebase.

kean avatar May 02 '24 11:05 kean

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23128-0dc1695
Version24.8
Bundle IDorg.wordpress.alpha
Commit0dc169502cc1ba8cec101d5610436464d11917b5
App Center BuildWPiOS - One-Offs #9768
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 02 '24 11:05 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23128-0dc1695
Version24.8
Bundle IDcom.jetpack.alpha
Commit0dc169502cc1ba8cec101d5610436464d11917b5
App Center Buildjetpack-installable-builds #8814
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 02 '24 11:05 wpmobilebot