[Hack Week] Post success view
Fixes #https://github.com/wordpress-mobile/WordPress-iOS/issues/21509.
I've been going through the maintenance board, noticed the linked defect, and decided to resurrect this PR from the last Hack Week, which I didn't get to complete then. The new screen looks more like what you see in Gutenberg, and has a new "Promote with Blaze" button.
The initial idea was to show this automatically as part of the Prepublishing sheet, but this is a more conservative approach that simply replaced the current screen (with a slightly broken layout).
The design comes from one of the prototypes made with Chris, but with some minor changes. There've been so many versions of this, I don't any particular direction was picked as the final one in the end.
To test:
- Publish a new post
- Tap "View" on a snackbar
- ✅ Verify that the updated success screen is shown
- ✅ Verify that all buttons are working
- ✅ Verify that for Blaze-enabled blogs, "Promote with Blaze" button is visible.
Regression Notes
- Potential unintended areas of impact: Post Publish Success Notice View
- What I did to test those areas of impact (or what existing automated tests I relied on): manual
- What automated tests I added (or what prevented me from doing so): n/a
PR submission checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
| 1 Warning | |
|---|---|
| :warning: | This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
Generated by :no_entry_sign: Danger
Hey, I updated the design based on what we discussed.
LGTM! Did you figure out the Podfile.lock issue?
Looks like it got updated in trunk. The change disappear after the rebase.
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23128-0dc1695 | |
| Version | 24.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0dc169502cc1ba8cec101d5610436464d11917b5 | |
| App Center Build | WPiOS - One-Offs #9768 |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23128-0dc1695 | |
| Version | 24.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0dc169502cc1ba8cec101d5610436464d11917b5 | |
| App Center Build | jetpack-installable-builds #8814 |