Update terminology to Subscribers from Followers

[staskus]

Fixes #21878

Update terminology to Subscribers from Followers in the app.

Other PRs that include renaming:

• https://github.com/wordpress-mobile/WordPress-iOS/pull/23084
• https://github.com/wordpress-mobile/WordPress-iOS/pull/23113

Solution

I used regex "follow\w*\b.*?" to find candidate strings for renaming:

There are follow/follower references left in other contexts. For example, Jetpack Social Connections, or Topics. I concentrated on Blog's Followers/Follows/Following/Followed cases.

Affected places:

• Reader (although most popular buttons and prompts already have subscribers used instead of followers, there were still some unchanged strings left)
• Notifications, NotificationSettings (similar to Stats it still used follower terminology)
• Insights -> Grow Audience cell
• Onboarding
• Jetpack overlay

To test:

1. Check localized string changes on the PR.
2. Check most prominent places:

• Notifications
• Notification Settings
• Reader
• Stats

Note: Not all the changes I made appear on the project since .strings file still contain old strings and require them to be regenerated and retranslated.

3. Review the project with this or similar regex "follow\w*\b.*?" to check if any strings are missed

Regression Notes

1. Potential unintended areas of impact

Make sure the strings are translated correctly at all the required places

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding unit tests for my changes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• [ ] WordPress.com sites and self-hosted Jetpack sites.
• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] VoiceOver.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] iPhone and iPad.
• [ ] Multi-tasking: Split view and Slide over. (iPad)

[staskus]

cc @aditi-bhatia since you work on this task on Android. There're quite a few references of followers in the app that I found besides Stats. Most notably Notifications and Reader.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23126-d1e2a1a
	Version	24.8
	Bundle ID	org.wordpress.alpha
	Commit	d1e2a1ab54727d31380621abe63266070b37b257
	App Center Build	WPiOS - One-Offs #9738

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23126-d1e2a1a
	Version	24.8
	Bundle ID	com.jetpack.alpha
	Commit	d1e2a1ab54727d31380621abe63266070b37b257
	App Center Build	jetpack-installable-builds #8783

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[aditi-bhatia]

cc @aditi-bhatia since you work on this task on Android. There're quite a few references of followers in the app that I found besides Stats. Most notably Notifications and Reader.

Thanks for the heads up @staskus! I'm noticing and addressing those on Android too 👍