WordPress-iOS
WordPress-iOS copied to clipboard
Reader: Add a footer view for the Reader tags feed
Fixes #23108
Description
Adds the "More" footer view to the Reader tags feed.
Note: There's an existing issue when navigating to a tag feed from the "Your Tags" feed. This is due to the following chain of events:
- A reader stream view controller is created with the tag slug
- A lookup happens and then the
readerTopic
of the stream view controller gets set - The
didSet
of thereaderTopic
sets theinUse
property on the tag managed object and the context is saved - The existing "Your Tags" feed now sees a change to the tag object
- That tag cell is reloaded
This causes the collection view offset to briefly show at the beginning, and then it'll update back to the end of the content when navigating back to the "Your Tags" feed from the tag feed.
I couldn't find a good way to fix this because it appears the inUse
property is currently used. I'll keep attempting to look for a solution.
Screenshots
Light | Dark |
---|---|
Testing
To test:
- Launch Jetpack and login
- Navigate to the "Your Tags" feed
- Scroll to the end of a tag's collection view
- π Verify the "More" footer view is styled correctly
- Tap on the view
- π Verify it navigates to that tag's feed
Regression Notes
-
Potential unintended areas of impact Should be none.
-
What I did to test those areas of impact (or what existing automated tests I relied on) N/A
-
What automated tests I added (or what prevented me from doing so) N/A PR submission checklist:
- [x] I have completed the Regression Notes.
- [x] I have considered adding unit tests for my changes.
- [x] I have considered adding accessibility improvements for my changes.
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isnβt complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
π² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23109-0a19acf | |
Version | 24.7 | |
Bundle ID | org.wordpress.alpha | |
Commit | 0a19acf816a4ed7a2a1edd0b6915bdc230fb4389 | |
App Center Build | WPiOS - One-Offs #9709 |
π² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23109-0a19acf | |
Version | 24.7 | |
Bundle ID | com.jetpack.alpha | |
Commit | 0a19acf816a4ed7a2a1edd0b6915bdc230fb4389 | |
App Center Build | jetpack-installable-builds #8753 |
Maybe at some point we can rewrite the stream view controller. There's a decent amount of strange behavior from the current one, which is very difficult to fix or track down.
We just need to fetch the tags once every time the stream is loaded or the user initiates a refresh gesture.
We'd still need to handle a user's tags changing, unless navigating back counts as loading. They can open one of the tag posts, then tap on a tag for that post, and follow it.
Thanks for the review!