Offline Mode: Add a way to cancel uploads directly from Media Uploads screen
Add a way to cancel uploads directly from the "Media Uploads" screen.
Note: this doesn't cover drafts sync yet, and I'm working on integrating this screen in more context, but wanted to keep the PRs small.
https://github.com/wordpress-mobile/WordPress-iOS/assets/1567433/9dae6e7c-6605-452d-a903-5b561ee3c6f0
https://github.com/wordpress-mobile/WordPress-iOS/assets/1567433/550a3bf6-c48a-4cb1-8e37-2b4ff7dcfe8a
To test:
- Use the steps from the following issue to create a post with a dangling media upload
- Tap "Publish"
- β Verify that the sheet shows a "Media failed to upload message" (it is a defect, but for the purposes of this PR, it's an expected behavior)
- Open "Media Uploads"
- Tap "More" and Tap "Cancel Upload" on the danling upload
- Tap "Back"
- β Verify that the "Publish" button is now available and you can publish the post
Regression Notes
-
Potential unintended areas of impact
-
What I did to test those areas of impact (or what existing automated tests I relied on)
-
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isnβt complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
π² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23102-4dba16a | |
| Version | 24.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 4dba16a90ffd59c77a0570235ce91d8e5780dee6 | |
| App Center Build | WPiOS - One-Offs #9720 |
π² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23102-4dba16a | |
| Version | 24.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 4dba16a90ffd59c77a0570235ce91d8e5780dee6 | |
| App Center Build | jetpack-installable-builds #8764 |
Hi @kean π , I'm bumping this PR's milestone to 24.9 since I'm starting code freeze. Feel free to re-target this to the release branch if this is a blocker or intended for 24.8.
| 1 Warning | |
|---|---|
| :warning: | This PR is assigned to the milestone 24.8 βοΈ. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished. |
Generated by :no_entry_sign: Danger