WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Offline Mode: Add a way to cancel uploads directly from Media Uploads screen

Open kean opened this issue 1 year ago β€’ 2 comments

Add a way to cancel uploads directly from the "Media Uploads" screen.

Note: this doesn't cover drafts sync yet, and I'm working on integrating this screen in more context, but wanted to keep the PRs small.

https://github.com/wordpress-mobile/WordPress-iOS/assets/1567433/9dae6e7c-6605-452d-a903-5b561ee3c6f0

https://github.com/wordpress-mobile/WordPress-iOS/assets/1567433/550a3bf6-c48a-4cb1-8e37-2b4ff7dcfe8a

To test:

  • Use the steps from the following issue to create a post with a dangling media upload
  • Tap "Publish"
  • βœ… Verify that the sheet shows a "Media failed to upload message" (it is a defect, but for the purposes of this PR, it's an expected behavior)
  • Open "Media Uploads"
  • Tap "More" and Tap "Cancel Upload" on the danling upload
  • Tap "Back"
  • βœ… Verify that the "Publish" button is now available and you can publish the post

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

kean avatar Apr 26 '24 14:04 kean

WordPress AlphaπŸ“² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23102-4dba16a
Version24.8
Bundle IDorg.wordpress.alpha
Commit4dba16a90ffd59c77a0570235ce91d8e5780dee6
App Center BuildWPiOS - One-Offs #9720
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 26 '24 14:04 wpmobilebot

Jetpack AlphaπŸ“² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23102-4dba16a
Version24.8
Bundle IDcom.jetpack.alpha
Commit4dba16a90ffd59c77a0570235ce91d8e5780dee6
App Center Buildjetpack-installable-builds #8764
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 26 '24 14:04 wpmobilebot

Hi @kean πŸ‘‹ , I'm bumping this PR's milestone to 24.9 since I'm starting code freeze. Feel free to re-target this to the release branch if this is a blocker or intended for 24.8.

dvdchr avatar Apr 29 '24 09:04 dvdchr

1 Warning
:warning: This PR is assigned to the milestone 24.8 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

dangermattic avatar Apr 29 '24 15:04 dangermattic