WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard
verified publisher icon wordpress-mobile

Stats Subscribers Deep link support

Open staskus opened this issue 1 year ago • 2 comments

Fixes #23047

Add support to deep link from /stats/subscribers/domain into the app.

To test:

Feature flag enabled

  1. Enable Stats Subscribers and Traffic feature flag
  2. Open wp.com/stats
  3. Try opening the app from stats/insights, stats/subscribers
  4. Confirm respective tabs on the app are opened
  5. Try opening the app from wp.com traffic tab with different days/weeks/months/years granularity selected
  6. Confirm Traffic tab is opened on the app with correct date picker granularity selected

https://github.com/wordpress-mobile/WordPress-iOS/assets/4062343/9475e808-475b-43dc-bcaa-53ff8d20e3d3

Feature flag disabled

  1. Disable Stats Subscribers and Traffic feature flag
  2. stats/subscribers should open a default insights tab
  3. Other routes should work as before

https://github.com/wordpress-mobile/WordPress-iOS/assets/4062343/aa2e4d55-2b25-43cb-be8b-7a557b5c8a34

Regression Notes

  1. Potential unintended areas of impact

Breaking functionality when feature flag is disabled

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

staskus avatar Apr 26 '24 11:04 staskus

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23100-28a64e5
Version24.7
Bundle IDorg.wordpress.alpha
Commit28a64e5bf569ea42db2145befde51a3373da6ecb
App Center BuildWPiOS - One-Offs #9724
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 26 '24 11:04 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23100-28a64e5
Version24.7
Bundle IDcom.jetpack.alpha
Commit28a64e5bf569ea42db2145befde51a3373da6ecb
App Center Buildjetpack-installable-builds #8768
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 26 '24 11:04 wpmobilebot

I also noticed that if the user explicitly taps the Day segment on the web's Subscribers tab, the URL becomes https://wordpress.com/stats/subscribers/day/mysite.wordpress.com

Great observation, @guarani, thanks!

staskus avatar Apr 30 '24 07:04 staskus