WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Stats: Total Subscribers Card

Open staskus opened this issue 1 year ago β€’ 2 comments

Fixes #23048

image

Solution

  1. Updated subscribersList to return both subscribers and subscribers totals since they come from the same endpoint
  2. Added Total Subscribers card, reusing the same UI from Insights

Note: Insights Totals Subscribers card may show different numbers since it also adds publicize numbers. Fix is made here https://github.com/wordpress-mobile/WordPress-iOS/pull/23099

To test:

  1. Enable Stats Traffic and Subscribers tab feature flag
  2. Open Stats -> Subscribers
  3. Confirm Total Subscribers card appears
  4. Compare the number with the web

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

  2. What automated tests I added (or what prevented me from doing so)

Added unit tests

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

staskus avatar Apr 25 '24 09:04 staskus

Jetpack AlphaπŸ“² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23084-c307735
Version24.7
Bundle IDcom.jetpack.alpha
Commitc307735074e4f8dd53ee8c33ce6cc46fcc91ea3d
App Center Buildjetpack-installable-builds #8777
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 25 '24 10:04 wpmobilebot

WordPress AlphaπŸ“² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23084-c307735
Version24.7
Bundle IDorg.wordpress.alpha
Commitc307735074e4f8dd53ee8c33ce6cc46fcc91ea3d
App Center BuildWPiOS - One-Offs #9732
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 25 '24 10:04 wpmobilebot

Hi @staskus @guarani, I just wanted to double check something since I'm working on this for Android. Are we planning to implement the % change detail at the bottom of this card during this iteration? I'm not sure if I missed a conversation about this somewhere but I noticed it was in the designs:

Screenshot 2024-04-29 at 10 56 28 PM

aditi-bhatia avatar Apr 30 '24 06:04 aditi-bhatia

I just wanted to double check something since I'm working on this for Android. Are we planning to implement the % change detail at the bottom of this card during this iteration? I'm not sure if I missed a conversation about this somewhere but I noticed it was in the designs

Good question, @aditi-bhatia. No, at least not in this iteration. πŸ‘

staskus avatar Apr 30 '24 07:04 staskus

I'm not sure if I missed a conversation about this somewhere but I noticed it was in the designs

I couldn't see the comparison label in the designs mentioned in the issue https://github.com/wordpress-mobile/WordPress-iOS/issues/23048. I'm just asking to double-check that we're looking at the same designs.

guarani avatar Apr 30 '24 14:04 guarani

Ah good catch πŸ€” I had been referencing this Figma IqhXWz3Iir7RMb5XH5gGfZ-fi-97_5069 from this discussion p1713440407948299-slack-C06BR07TJHK which looks like was a previous iteration. Thanks both!

aditi-bhatia avatar Apr 30 '24 17:04 aditi-bhatia