Stats: Total Subscribers Card
Fixes #23048
Solution
- Updated
subscribersListto return both subscribers and subscribers totals since they come from the same endpoint - Added Total Subscribers card, reusing the same UI from Insights
Note: Insights Totals Subscribers card may show different numbers since it also adds publicize numbers. Fix is made here https://github.com/wordpress-mobile/WordPress-iOS/pull/23099
To test:
- Enable Stats Traffic and Subscribers tab feature flag
- Open Stats -> Subscribers
- Confirm Total Subscribers card appears
- Compare the number with the web
Regression Notes
- Potential unintended areas of impact
None
-
What I did to test those areas of impact (or what existing automated tests I relied on)
-
What automated tests I added (or what prevented me from doing so)
Added unit tests
PR submission checklist:
- [x] I have completed the Regression Notes.
- [x] I have considered adding unit tests for my changes.
- [x] I have considered adding accessibility improvements for my changes.
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isnβt complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
π² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23084-c307735 | |
| Version | 24.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c307735074e4f8dd53ee8c33ce6cc46fcc91ea3d | |
| App Center Build | jetpack-installable-builds #8777 |
π² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23084-c307735 | |
| Version | 24.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c307735074e4f8dd53ee8c33ce6cc46fcc91ea3d | |
| App Center Build | WPiOS - One-Offs #9732 |
Hi @staskus @guarani, I just wanted to double check something since I'm working on this for Android. Are we planning to implement the % change detail at the bottom of this card during this iteration? I'm not sure if I missed a conversation about this somewhere but I noticed it was in the designs:
I just wanted to double check something since I'm working on this for Android. Are we planning to implement the % change detail at the bottom of this card during this iteration? I'm not sure if I missed a conversation about this somewhere but I noticed it was in the designs
Good question, @aditi-bhatia. No, at least not in this iteration. π
I'm not sure if I missed a conversation about this somewhere but I noticed it was in the designs
I couldn't see the comparison label in the designs mentioned in the issue https://github.com/wordpress-mobile/WordPress-iOS/issues/23048. I'm just asking to double-check that we're looking at the same designs.
Ah good catch π€ I had been referencing this Figma IqhXWz3Iir7RMb5XH5gGfZ-fi-97_5069 from this discussion p1713440407948299-slack-C06BR07TJHK which looks like was a previous iteration. Thanks both!