WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

[Notification Refresh] Replace the old Comment Detail header with the new Content Preview component

Open salimbraksa opened this issue 10 months ago • 4 comments

Fixes https://github.com/Automattic/wordpress-mobile/issues/29

Post Preview Comment Preview Comment Preview without avatar
image

Test Instructions

Post Reply Notification

  1. Run Jetpack and login
  2. Navigate to the Notifications screen
  3. Find a Post Reply notification and click it
  4. The header should be the same as the design
  5. Click on the header, it should keep the original behavior

Comment Reply Notification

  1. Run Jetpack and login
  2. Navigate to the Notifications screen
  3. Find a Comment Reply notification and click it
  4. The header should be the same as the design
  5. Click on the header, it should keep the original behavior

Regression Notes

  1. Potential unintended areas of impact The behavior when the header is tapped should be maintained.

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Manual testing

  3. What automated tests I added (or what prevented me from doing so) None.

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [x] WordPress.com sites and self-hosted Jetpack sites.
  • [x] Portrait and landscape orientations.
  • [x] Light and dark modes.
  • [x] Fonts: Larger, smaller and bold text.
  • [x] High contrast.
  • [x] VoiceOver.
  • [x] Languages with large words or with letters/accents not frequently used in English.
  • [x] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [x] iPhone and iPad.
  • [x] Multi-tasking: Split view and Slide over. (iPad)

salimbraksa avatar Apr 25 '24 09:04 salimbraksa

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23083-e8a5b25
Version24.7
Bundle IDorg.wordpress.alpha
Commite8a5b251b7fd5bd7f02c5d3a94ed6e22b781300c
App Center BuildWPiOS - One-Offs #9713
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 25 '24 09:04 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23083-e8a5b25
Version24.7
Bundle IDcom.jetpack.alpha
Commite8a5b251b7fd5bd7f02c5d3a94ed6e22b781300c
App Center Buildjetpack-installable-builds #8757
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Apr 25 '24 09:04 wpmobilebot

There is a case when a comment is opened by ReaderCommentsViewController on top of CommentDetailViewController.

This behavior was developed in the 1st phase where we redirect the user directly to Reader Comments screen if they don't permission to moderate the comment.

Also based on the View Debugger screenshot you shared, the Reader Comments screen is a child of NotificafionCommentDetailViewController, not CommentDetailViewController, which are 2 different view controllers.

As for old header design in the Reader Comments, I intentionally avoided redesigning it because I think it's out of scope of this phase. 🤔

salimbraksa avatar Apr 26 '24 19:04 salimbraksa

This behavior was developed in the 1st phase where we redirect the user directly to Reader Comments screen if they don't permission to moderate the comment.

Yeah, totally understand it, but the screen looks like a notification detail and does even have navigation buttons on the toolbar. That's why it looks confusing and not organically within the brand-new design system. 🤔

justtwago avatar Apr 26 '24 20:04 justtwago