WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard
verified publisher icon wordpress-mobile

Address NoticePresenter iPad rotation workaround

Open megmil opened this issue 1 year ago • 3 comments

Fixes #11900

To test: Reproduce steps in #11345

iPad Air Simulator iPhone 15 Simulator
ezgif com-video-to-gif-converter iphonetest-ezgif com-video-to-gif-converter (1)

Description

New solution for bug in #11345 (Fix Notices showing anywhere but the bottom on iPad devices)

Regression Notes

  1. Potential unintended areas of impact Notices on iPhone Split view

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Tested on iPhone 15 simulator

  3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [x] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [x] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

megmil avatar Apr 22 '24 03:04 megmil

@justtwago @dvdchr @guarani @wargcm Could someone review this or let me know if there's any other steps to complete before this can be looked at?

megmil avatar Apr 24 '24 17:04 megmil

Hi @megmil, thanks for your contribution!

I couldn't reproduce the issue with the notices disappearing on the iPad. The notices appear if I go to Posts or Pages and turn off the internet. As I rotate the device's orientation, the notices work as expected (they move so they're always at the bottom of the screen, no matter the orientation). I'm testing on a physical iPad 8th generation (iPadOS 16.3).

Could you please verify the issue is present on the latest trunk commit? If so, please file an issue with steps to reproduce.

Fixes #11900

Just a note: this should point to an open issue, not a PR.

guarani avatar May 06 '24 19:05 guarani

Hi @guarani! The issue isn't the notices disappearing on iPad (anymore)--that was fixed in #11345. However, the fix in #11345 was a workaround "hack", and Apple engineers recommended a different way to fix it, according to #11900. That's what I implemented here.

My bad with the PR/bug thing. I just saw that it was marked as "Good First Issue."

megmil avatar May 07 '24 04:05 megmil