WordPress-iOS
WordPress-iOS copied to clipboard
Improve performance of File block processor
This PR follows the same approach taken in https://github.com/wordpress-mobile/WordPress-iOS/pull/22896 to improve the performance of Gutenberg processors. The overall improvement will be less significant in this case (that's why the PR is marked as Enhancement instead of Bug) mainly because the File block is used by fewer users than Image/Gallery blocks. Nevertheless, it will speed up the post-saving process.
To test:
Follow the testing instructions to cover the functionality related to the processors for the block:
- File Block:
Regression Notes
-
Potential unintended areas of impact The block processors are only used when saving a post. No other area should be impacted.
-
What I did to test those areas of impact (or what existing automated tests I relied on) Manually tested saving a post with File blocks.
-
What automated tests I added (or what prevented me from doing so) I added a new unit test to cover the content parsing of File blocks.
PR submission checklist:
- [x] I have completed the Regression Notes.
- [ ] I have considered adding unit tests for my changes.
- [ ] I have considered adding accessibility improvements for my changes.
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
Testing checklist:
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] VoiceOver.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isnβt complete, formatting should still respect the right-to-left layout)
- [ ] iPhone and iPad.
- [ ] Multi-tasking: Split view and Slide over. (iPad)
π² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22897-a9c30fb | |
| Version | 24.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a9c30fb61c9ace7d5bbe54a2ef0b5edcf7dacc22 | |
| App Center Build | WPiOS - One-Offs #9943 |
π² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22897-a9c30fb | |
| Version | 24.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a9c30fb61c9ace7d5bbe54a2ef0b5edcf7dacc22 | |
| App Center Build | jetpack-installable-builds #8993 |
I'm moving this to the next milestone since this is not a blocker, and the code freeze will be completed today.
π Hey @fluiddot, I'm bumping this PR to 24.8 since it's code freeze day. If this PR needs to target 24.7, please target the release branch once it's been cut. Thanks!
Hi @fluiddot π , I'm bumping this PR's milestone to 24.9 since I'm starting code freeze. Feel free to re-target this to the release branch if this is a blocker or intended for 24.8.
Hey @fluiddot, I'm bumping the milestone for this PR to 25.0 as I'm starting the code freeze. If this PR needs to go into 24.9, please go ahead and re-target it to the release branch.