WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Improve performance of File block processor

Open fluiddot opened this issue 1 year ago β€’ 6 comments
trafficstars

This PR follows the same approach taken in https://github.com/wordpress-mobile/WordPress-iOS/pull/22896 to improve the performance of Gutenberg processors. The overall improvement will be less significant in this case (that's why the PR is marked as Enhancement instead of Bug) mainly because the File block is used by fewer users than Image/Gallery blocks. Nevertheless, it will speed up the post-saving process.

To test:

Follow the testing instructions to cover the functionality related to the processors for the block:

Regression Notes

  1. Potential unintended areas of impact The block processors are only used when saving a post. No other area should be impacted.

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Manually tested saving a post with File blocks.

  3. What automated tests I added (or what prevented me from doing so) I added a new unit test to cover the content parsing of File blocks.

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

fluiddot avatar Mar 25 '24 16:03 fluiddot

WordPress AlphaπŸ“² You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22897-a9c30fb
Version24.9
Bundle IDorg.wordpress.alpha
Commita9c30fb61c9ace7d5bbe54a2ef0b5edcf7dacc22
App Center BuildWPiOS - One-Offs #9943
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Mar 25 '24 16:03 wpmobilebot

Jetpack AlphaπŸ“² You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22897-a9c30fb
Version24.9
Bundle IDcom.jetpack.alpha
Commita9c30fb61c9ace7d5bbe54a2ef0b5edcf7dacc22
App Center Buildjetpack-installable-builds #8993
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Mar 25 '24 16:03 wpmobilebot

I'm moving this to the next milestone since this is not a blocker, and the code freeze will be completed today.

irfano avatar Apr 01 '24 13:04 irfano

πŸ‘‹ Hey @fluiddot, I'm bumping this PR to 24.8 since it's code freeze day. If this PR needs to target 24.7, please target the release branch once it's been cut. Thanks!

momo-ozawa avatar Apr 15 '24 12:04 momo-ozawa

Hi @fluiddot πŸ‘‹ , I'm bumping this PR's milestone to 24.9 since I'm starting code freeze. Feel free to re-target this to the release branch if this is a blocker or intended for 24.8.

dvdchr avatar Apr 29 '24 08:04 dvdchr

Hey @fluiddot, I'm bumping the milestone for this PR to 25.0 as I'm starting the code freeze. If this PR needs to go into 24.9, please go ahead and re-target it to the release branch.

salimbraksa avatar May 13 '24 20:05 salimbraksa