Fix pre-publishing sheet analytics

[kean]

Fixes a regression in 24.3 where the pre-publishing sheet would sometimes call the "dismissed" callback together with "completed". It doesn't introduce any functional issues, so it was unnoticed, but there is an issue with analytics.

To test:

• Set debugger PostEditor+Publish on publishBlock and the dismiss closure below
• Tap "Publish"
• Tap "Close" and verify that only dismiss closure is called
• Tap "Publish"
• Tap outside of the sheet and verify that only dismiss closure is called
• Tap "Publish"
• Add a tag and verify that the dismiss close is not called
• Tap "Publish"
• Confirm publishing and verify that only publishBlock closure is called

Regression Notes

1. Potential unintended areas of impact: Pre-publishing Sheet
2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

• [ ] I have completed the Regression Notes.
• [ ] I have considered adding unit tests for my changes.
• [ ] I have considered adding accessibility improvements for my changes.
• [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• [ ] WordPress.com sites and self-hosted Jetpack sites.
• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] VoiceOver.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] iPhone and iPad.
• [ ] Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	1 Warning
:warning:	This PR is assigned to the milestone 24.3 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22697-96e1d7e
	Version	24.3
	Bundle ID	org.wordpress.alpha
	Commit	96e1d7e7fd97698785e9f3768d190ea3e93621bd
	App Center Build	WPiOS - One-Offs #8954

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22697-96e1d7e
	Version	24.3
	Bundle ID	com.jetpack.alpha
	Commit	96e1d7e7fd97698785e9f3768d190ea3e93621bd
	App Center Build	jetpack-installable-builds #7984

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.