WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Offline Mode: Draft sync states

Open momo-ozawa opened this issue 1 year ago • 4 comments

Part of #22578

Description

  • Adds new "sync states" for draft post cells (idle, syncing, offline changes, failed)
  • Removing the status label will be addressed in a future PR (https://github.com/wordpress-mobile/WordPress-iOS/pull/22648)

How to test

  • Open a draft
  • Verify the following conditions based on the state
State Activity indicator? Icon? Ellipsis button?
Idle (Successfully uploaded) No No Yes
Syncing (Uploading, trashing) Yes No No
Offline changes (No internet connection) No Yes Yes
Failed (Other errors) No Yes Yes

Regression Notes

  1. Potential unintended areas of impact Post cell

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Added tests for the view model

  3. What automated tests I added (or what prevented me from doing so) Added tests for the view model

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

momo-ozawa avatar Feb 19 '24 16:02 momo-ozawa

1 Warning
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by :no_entry_sign: Danger

dangermattic avatar Feb 19 '24 16:02 dangermattic

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22634-4e23acb
Version24.4
Bundle IDorg.wordpress.alpha
Commit4e23acb07d4661277df8981fc321d7baa9a2c71e
App Center BuildWPiOS - One-Offs #9082
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Feb 19 '24 16:02 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22634-4e23acb
Version24.4
Bundle IDcom.jetpack.alpha
Commit4e23acb07d4661277df8981fc321d7baa9a2c71e
App Center Buildjetpack-installable-builds #8125
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Feb 19 '24 16:02 wpmobilebot

One issue to note: when there are offline changes and you re-enable the connection, the post don't actually get updated immediately.

kean avatar Feb 20 '24 16:02 kean