WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Cannot form weak reference to instance of class PUPickerRemoteViewController

Open staskus opened this issue 1 year ago • 2 comments

Cannot form weak reference to instance (0x109349a00) of class PUPickerRemoteViewController. It is possible that this object was over-released, or is in the process of deallocation. > objc[2323]: Cannot form weak reference to instance (0x109349a00) of class PUPickerRemoteViewController. It is possible that this object was over-released, or is in the process of deallocation.

Sentry

The crash is grouped with other SIGABRT crashes on Jetpack and WordPress. However, the current spike is mostly related to PUPickerRemoteViewController:

Observations

  • iPad only
  • PHPickerViewController (and consequentially PUPickerRemoteViewController) doesn’t get deallocated, since it’s held strongly by AztecPostViewController (https://github.com/wordpress-mobile/WordPress-iOS/blob/9ee96a5a70988ff877793c6c30dc701b9285433b/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift#L426). We could make it weak and keep it same behavior.
  • AztecPostViewController contains code, with a comment We need to auto-close the input media picker when multitasking panes are resized:
if UIDevice.isPad() {
   closeMediaPickerInputViewController()
}

Steps to reproduce the behavior

Tested on [device], iOS [version], Jetpack iOS / WordPress iOS [version]

staskus avatar Feb 01 '24 13:02 staskus

Sentry issue: WORDPRESS-IOS-58Z

sentry-io[bot] avatar Feb 01 '24 21:02 sentry-io[bot]

Since we silenced this in Sentry (see p1712240165775319/1712109956.629519-slack-C012H19SZQ8), I moved this to a new "On Hold" status on the Release Rotation board (https://github.com/orgs/wordpress-mobile/projects/236/views/7) and unassigned you @kean.

guarani avatar Apr 08 '24 19:04 guarani