WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

[Gutenberg] Highlight text bug fixes

Open geriux opened this issue 1 year ago • 3 comments

Related PRs:

  • https://github.com/wordpress-mobile/gutenberg-mobile/pull/6517
  • https://github.com/WordPress/gutenberg/pull/57650
  • https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1352

Fixes several issues related to the Highlight text formatting in the Gutenberg editor.


To Test:

Please check the testing instructions in the Gutenberg PR description.


Regression Notes

  1. Potential unintended areas of impact

    • It should only affect the editor.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing, and integration tests in both Aztec and Gutenberg.
  3. What automated tests I added (or what prevented me from doing so)

    • Visual E2E tests added in Gutenberg Mobile.

PR Submission Checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

geriux avatar Jan 19 '24 15:01 geriux

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22425-0b97ec3
Version24.5
Bundle IDorg.wordpress.alpha
Commit0b97ec3ad08fc84bc95de3cf19e3a249707239df
App Center BuildWPiOS - One-Offs #9229
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Jan 19 '24 16:01 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22425-0b97ec3
Version24.5
Bundle IDcom.jetpack.alpha
Commit0b97ec3ad08fc84bc95de3cf19e3a249707239df
App Center Buildjetpack-installable-builds #8274
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Jan 19 '24 16:01 wpmobilebot

I'm going to bump this to the next release because we'll be code freezing 24.3 today and it seems like this has not been approved yet.

For the record, I also checked the Gutenberg PR in the hope that it was already merged and shipped, meaning this PR could be closed as the changes would be fetched as part of the next Gutenberg release, but that was not the case.

mokagio avatar Feb 19 '24 00:02 mokagio

Hey @twstokes 👋 I was wondering if you'd be able to review this PR if you have some time. It only updates the Aztec and Gutenberg references, although it won't be merged until both Gutenberg Mobile and Aztec have their new tag released with the new changes. Thank you!

geriux avatar Mar 18 '24 14:03 geriux