WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard
verified publisher icon wordpress-mobile

[Jetpack plugin install prompt] Complete UI and tracking for installation prompt

Open staskus opened this issue 3 years ago • 3 comments

Description

This pull request completes Phase 1 of Jetpack plugin install prompt project https://github.com/wordpress-mobile/WordPress-iOS/issues/19213

  • Updating UI according to the new requirements
  • Adding tracking

Testing instructions

Case 1:

  1. Fresh install app and log in to self-hosted site without Jetpack
  2. Install prompt appears
  3. There's a title and description informing about Jetpack features
  4. "Learn more" button opens the web site
  5. "Install Jetpack" button opens installation flow
  6. "Continue without Jetpack" dismisses

Case 2 - Tracking

  1. Fresh install app and log in to self-hosted site without Jetpack
  2. Install prompt appears
  3. Tracked: jetpack_install_prompt_shown <site_type: blog> appears in console
  4. Tap "Learn more"
  5. Tracked: jetpack_install_prompt_learn_more_tapped <site_type: blog> appears in console
  6. Tap "Install"
  7. Tracked: jetpack_install_prompt_install_tapped <site_type: blog> appears in console
  8. Come back and tap "Continue without Jetpack"
  9. Tracked: jetpack_install_prompt_dismiss_tapped <site_type: blog> appears in console

Regression Notes

  1. Potential unintended areas of impact

Broken actions or accessibility

  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Tested actions manually
  • Tested accessibility using accessibility inspector, different screen sizes and different dynamic text size
  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Images & Videos

iPhone 13

iPhone 13 + Zoomed

iPad Pro 12.9 inch

Tracking

tracked events

staskus avatar Sep 21 '22 09:09 staskus

You can test the changes in WordPress from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19330-3e18515 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Sep 21 '22 10:09 wpmobilebot

You can test the changes in Jetpack from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19330-3e18515 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Sep 21 '22 10:09 wpmobilebot

@sla8c

Thank you for the review 🤝, good catch!

I made a change to support dark mode.

https://user-images.githubusercontent.com/4062343/191737893-3f1cccd7-d337-474f-9a09-4f96faea136b.mp4

staskus avatar Sep 22 '22 11:09 staskus

Nice work adapting this to the new design and adding tracks ✨

The code looks good and I run through the testing instructions and everything worked well. I also tested dark mode which @sla8c flagged earlier and it's fixed.

The only comment was on this Figma board: 7Xi0UHNwokIWen0cczwHti-fi-0%3A1 (I can't link to the specific comment since the link shorter doesn't seem to support Figma comments yet, see 152-gh-Automattic/tampermonkey-highlighter). This is not a blocker since this PR is not being merged to trunk, but I was reminded of it on this PR and have pinged folks in that Figma comment thread for feedback.

Thanks 👍 Yes, I saw the comment. I agree that for now it's not worth waiting and texts could be changed later in case the feature is released.

staskus avatar Sep 23 '22 06:09 staskus