WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Add app groups and keychain access groups to Jetpack release entitlements

Open wargcm opened this issue 3 years ago • 3 comments

Description

Adds app group and keychain access group entitlements to Jetpack's release entitlements. These are used by both shared user data and shared login.

This is just adding the entitlements and does not actually enable any features.

cc: @mokagio

Regression Notes

  1. Potential unintended areas of impact N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on) N/A

  3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wargcm avatar Sep 20 '22 22:09 wargcm

You can test the changes in WordPress from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19328-918f6f1 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Sep 20 '22 23:09 wpmobilebot

Thanks for working on this @wargcm.

I noticed the Jetpack installable build has failed, during archiving. I can't find the exact error in the logs, but it wouldn't surprise me if it was due to the local entitlements not being in sync with the ones in the developer portal.

I'll be AFK for the next couple of days. If this is urgent and you need help with this, ping @wordpress-mobile/apps-infrastructure.

mokagio avatar Sep 21 '22 11:09 mokagio

Thanks @mokagio!

@wordpress-mobile/apps-infrastructure is this something I could get help with?

wargcm avatar Sep 21 '22 20:09 wargcm

it wouldn't surprise me if it was due to the local entitlements not being in sync with the ones in the developer portal.

Screen Shot 2022-09-26 at 1 19 36 pm

Bullseye 🎯

mokagio avatar Sep 26 '22 03:09 mokagio

I fixed the provisioning profiles via match

image

This is what Xcode shows me now:

image

Because the fix was unrelated with the code here, I restarted the Installable Build job. I expect it to pass ( 🤞 )

mokagio avatar Sep 26 '22 03:09 mokagio

You can test the changes in Jetpack from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19328-918f6f1 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Sep 26 '22 04:09 wpmobilebot

The installable build step was successful at last 😄

mokagio avatar Sep 26 '22 04:09 mokagio

Thanks @mokagio!

wargcm avatar Sep 26 '22 15:09 wargcm