WordPress-iOS
WordPress-iOS copied to clipboard
Add app groups and keychain access groups to Jetpack release entitlements
Description
Adds app group and keychain access group entitlements to Jetpack's release entitlements. These are used by both shared user data and shared login.
This is just adding the entitlements and does not actually enable any features.
cc: @mokagio
Regression Notes
-
Potential unintended areas of impact N/A
-
What I did to test those areas of impact (or what existing automated tests I relied on) N/A
-
What automated tests I added (or what prevented me from doing so) N/A
PR submission checklist:
- [x] I have completed the Regression Notes.
- [x] I have considered adding unit tests for my changes.
- [x] I have considered adding accessibility improvements for my changes.
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
You can test the changes in WordPress from this Pull Request by:
- Clicking here or scanning the QR code below to access App Center
- Then installing the build number
pr19328-918f6f1on your iPhone
Thanks for working on this @wargcm.
I noticed the Jetpack installable build has failed, during archiving. I can't find the exact error in the logs, but it wouldn't surprise me if it was due to the local entitlements not being in sync with the ones in the developer portal.
I'll be AFK for the next couple of days. If this is urgent and you need help with this, ping @wordpress-mobile/apps-infrastructure.
Thanks @mokagio!
@wordpress-mobile/apps-infrastructure is this something I could get help with?
it wouldn't surprise me if it was due to the local entitlements not being in sync with the ones in the developer portal.
Bullseye 🎯
I fixed the provisioning profiles via match

This is what Xcode shows me now:
Because the fix was unrelated with the code here, I restarted the Installable Build job. I expect it to pass ( 🤞 )
You can test the changes in Jetpack from this Pull Request by:
- Clicking here or scanning the QR code below to access App Center
- Then installing the build number
pr19328-918f6f1on your iPhone
The installable build step was successful at last 😄
Thanks @mokagio!