WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Published 20 hours ago • verified publisher icon wordpress-mobile

Jetpack Focus: Recommend App

Open momo-ozawa opened this issue 2 years ago • 2 comments

Part of #19164

Description

  • Updated Me screen to display the Recommended App section
  • Removed aboutScreen feature flag
  • Removed obsolete about view controller files
  • Updated share presenter in Me screen to present correct share sheet depending on the app
Share sheet Unified About screen Me screen
Simulator Screen Shot - iPhone 13 - 2022-08-11 at 11 39 32 Simulator Screen Shot - iPhone 13 - 2022-08-11 at 11 39 26 Simulator Screen Shot - iPhone 13 - 2022-08-11 at 11 39 17
-- -- --
Simulator Screen Shot - iPhone 13 - 2022-08-11 at 11 38 59 Simulator Screen Shot - iPhone 13 - 2022-08-11 at 11 38 54 Simulator Screen Shot - iPhone 13 - 2022-08-11 at 11 38 42

How to test

Test on both WP and JP using a real device

Me screen

  1. Go to My Site and tap on your profile icon
  2. ✅ Verify: "Share with a friend" is dispalyed
  3. Tap on the "Share with a friend" row and send the link to yourself
  4. Delete the app
  5. Tap on the link you just shared in step 3
  6. ✅ Verify: The correct app is dispalyed on the App Store

Unified About screen

  1. Go to My Site > Profile Icon > About
  2. ✅ Verify: "Share with Friends" is dispalyed
  3. Tap on the "Share with Friends" row and send the link to yourself
  4. Delete the app
  5. Tap on the link you just shared in step 3
  6. ✅ Verify: The correct app is dispalyed on the App Store

Regression Notes

  1. Potential unintended areas of impact
  • Recommending the app on WP
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Tested the steps above
  1. What automated tests I added (or what prevented me from doing so)
  • N/A

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

momo-ozawa avatar Aug 11 '22 10:08 momo-ozawa

You can test the changes in Jetpack from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19174-bee2330 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Aug 11 '22 11:08 wpmobilebot

You can test the changes in WordPress from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19174-bee2330 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Aug 11 '22 11:08 wpmobilebot