WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

[Jetpack] Reader -> Site search: Add Jetpack banner

Open twstokes opened this issue 3 years ago • 2 comments

Fixes #19129

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

twstokes avatar Aug 10 '22 02:08 twstokes

You can test the changes in Jetpack from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19166-2414020 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Aug 10 '22 02:08 wpmobilebot

You can test the changes in WordPress from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19166-2414020 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Aug 10 '22 02:08 wpmobilebot

TODO: After fixing the merge conflict, attach the overlay presentation action as noted here.

twstokes avatar Aug 16 '22 15:08 twstokes

TODO: After fixing the merge conflict, attach the overlay presentation action as noted here.

Done. The action already worked because this view uses the JP banner VC wrapper. 🎉

twstokes avatar Aug 16 '22 18:08 twstokes