WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

removed forced try & unwrap

Open entunidotdeb opened this issue 2 years ago • 3 comments

Fixes # Safety checks: removed forced try & forced unwrap to avoid crash

entunidotdeb avatar Aug 03 '22 15:08 entunidotdeb

Warnings
:warning: PR is not assigned to a milestone.
:warning: PR is missing at least one label.

Generated by :no_entry_sign: dangerJS

@entunidotdeb just a note to say I "took over" your work in #19167 to 1) run all the CI checks on it (which don't run on external contributor PRs) and 2) add some additional tweaks.

I cherry picked your commit, so once merged you should appear in the list of contributors.

Also, once #19167 merges this PR should automatically be marked as merged, too.

Thank you so much for your help!

mokagio avatar Aug 11 '22 01:08 mokagio

@mokagio thank you so much for informing. Just to confirm here, are CI checks supposed to run automatically on contributor's PR ? Happy to help more :)

entunidotdeb avatar Aug 11 '22 14:08 entunidotdeb

Just to confirm here, are CI checks supposed to run automatically on contributor's PR ?

Not the full CI suite. For example, this PR has 2 successful checks:

image

But a maintainer PR has 20:

image

mokagio avatar Aug 12 '22 04:08 mokagio

Ops, sorry, I didn't realize there was an open PR targeting my PR branch. But luckily Gio's PR got me covered. 😸

crazytonyli avatar Aug 15 '22 09:08 crazytonyli