WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Reader > Search: Jetpack banner is visible and animated in 'No posts found' screen.

Open tiagomar opened this issue 3 years ago • 2 comments

Jetpack banner is responding to scroll up/down gestures in Reader > Search > 'No posts found' screen. The same thing happens for the Unable to load this content right now screen.

Steps to reproduce the behavior

  1. Open the app.
  2. Go to Reader.
  3. Tap Search button.
  4. Type several letters in the search field to the result is the No posts found screen.
  5. Swipe the screen up and down.
  6. ❌ Notice the Jetpack banner is responding to scrolling up/down gestures.
  7. Turn the Airplane mode ON.
  8. Search for something.
  9. Notice the Unable to load this content right now screen is displayed.
  10. Swipe the screen up and down.
  11. ❌ Notice the Jetpack banner is responding to scrolling up/down gestures.

tiagomar avatar Jul 21 '22 21:07 tiagomar

@tiagomar @twstokes , just a thought here: is the issue that the banner responds to the scroll events, or that the no result views are still bouncing? I'm fine with both approaches (and I agree that this is a low priority issue), just wanted to share this thought.

Gio2018 avatar Aug 05 '22 16:08 Gio2018

Good question @Gio2018! The requirements actually changed a bit since I filed this ticket (I'll update the description), now we do expect the banner to be displayed in Reader Search results, so the weirdness would be the banner hiding and reappearing when the screen is not actually scrolled.

Removing the bouncing sounds like simplest fix to the rookie in me. =P

It's good to notice that the Banner in Reader Search results is still not present in Android as of 20.4.

tiagomar avatar Aug 05 '22 20:08 tiagomar