WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Published 20 hours ago • verified publisher icon wordpress-mobile

Fix app icon warning

Open guarani opened this issue 3 years ago • 5 comments

Closes #18958

The app icon for the WordPress target was added to the membership of the Jetpack app. I don't think the Jetpack app needs access to the WordPress app icon, so I've removed its membership in this PR.

Looking at the code via git blame, it looks like this the WordPress app icon has been part of Jetpack since early 2021, so this isn't a new issue.

To test:

Install both the Jetpack and the WordPress apps from this PR and verify that each has their correct app icon on the device's home screen (green for Jetpack, light blue for WordPress).

Regression Notes

  1. Potential unintended areas of impact

This PR assumes that the WordPress app icon is not used anywhere within Jetpack. If that assumption is false, this change might break some parts of the Jetpack app.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

TO-DO

  1. What automated tests I added (or what prevented me from doing so)

Since this affects the app icon, there are no existing tests and adding automated tests is not feasible.

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

guarani avatar Jun 29 '22 15:06 guarani

You can test the changes in Jetpack from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18963-563f932 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Jun 29 '22 16:06 wpmobilebot

You can test the changes in WordPress from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18963-563f932 on your iPhone
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot avatar Jun 29 '22 16:06 wpmobilebot

The app icon for the WordPress target was added to the membership of the Jetpack app. I don't think the Jetpack app needs access to the WordPress app icon, so I've removed its membership in this PR.

This approach isn't working, I inadvertently excluded all AppImages instead of just the app icon, from the Jetpack app. Will need to try a different approach.

guarani avatar Jun 29 '22 19:06 guarani

Pushing this PR to the next milestone, 20.4, because I'm running the 20.3 code-freeze today and this is still a draft.

mokagio avatar Jul 10 '22 19:07 mokagio

Thanks @mokagio! I removed the milestone since I'm not working on this right now.

If this is urgent please let me know, if not, I'll leave this open until I can tackle it (or someone else proposes a solution).

guarani avatar Jul 11 '22 13:07 guarani

👋 I'm going to close this PR due to lack of activity, but please reopen if this was an error. Thank you.

twstokes avatar Aug 25 '23 21:08 twstokes