Stats Revamp: Fix Followers Details Screen Followers Total

[sla8c]

This PR adds more stability for the top Followers Total card on the 2nd level Stats Insights screen. During testing it was noted that Followers Total could be showing 0 on the top card even though there are followers.

I hadn't appreciated that StatsInsightsStore has 2 methods of requesting followers for example:

• dotComFollowers
• allDotComFollowers

For the purposes of the Followers Total card summary, I've changed the call to use the dotComFollowers which returns quicker and is consistent with the Top Level Followers Total insights card

Ref #18605

Screenshot below of the problem. Note that this inconsistent Followers Total count does not always manifest (I could only get it to happen 1 out of 20 times)

Expected result:

To test: 1. enable both of the new stats feature flags statsNewAppearance and statsNewInsights via AppConfiguration.showsStatsRevampV2 2. From top level Stats Insights screen, Find the Followers Total card (or add if needed) and take note of the count. Then tap "View More" on the Followers Total card. You should be taken to the 2nd Level Insights Details and should see Followers Total card at the top 3. The count of the Followers Total card on the 2nd level should match the count of the Followers Total card on the top level Switch sites and continue to test this for other sites

Regression Notes

1. Potential unintended areas of impact Stats revamp v2

2. What I did to test those areas of impact (or what existing automated tests I relied on) Manually tested

3. What automated tests I added (or what prevented me from doing so) None

PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding unit tests for my changes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[sla8c]

I've set this to @guarani for review and cc @frosty for fyi. Thanks

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr18951-7664b28 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr18951-7664b28 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[staskus]

I see that "before" screenshot shows the date switcher while "expected" screenshot doesn't show the date switcher on top.

Is it also related to this change? What is the expectation?

[staskus]

✅ Tested. Followers counts match at both levels. The count also matches the web.

[sla8c]

I see that "before" screenshot shows the date switcher while "expected" screenshot doesn't show the date switcher on top.

Is it also related to this change? What is the expectation?

I think that's as a result of stats revamp being in flux at that time the PR was created months ago. The expectation is for the date switcher to not be there (and its not there now). It was determined that the date switcher was not needed for 'Totals'

[staskus]

think that's as a result of stats revamp being in flux at that time the PR was created months ago. The expectation is for the date switcher to not be there (and its not there now). It was determined that the date switcher was not needed for 'Totals'

@sla8c

I noticed that there're 2 different followers views:

• Insights -> Followers (Contains data picker)
• Insights -> Total Followers (Doesn't contain data picker)

However, I think both shouldn't contain a data picker.

Created an issue https://github.com/wordpress-mobile/WordPress-iOS/issues/19763