WordPress-iOS
WordPress-iOS copied to clipboard
Streamline and update `Rakefile`
trafficstars
While working on #18845 and #18850, I noticed a few things that could be improved in the Rakefile:
- DRY how we load
Podfile.lock - We have tasks such as
testandcleanthat are redundant given our use of Fastlane. We should either remove them or make them run the appropriate Faslane lane under the hood.
https://github.com/wordpress-mobile/WordPress-iOS/blob/2185a1e1c2cdaa0b089e93ba75b315e058f360ce/Rakefile#L216-L224
- Same goes for this custom
xcodebuildcall. Fastlane can do this for us with extra parameter and safety checks.
https://github.com/wordpress-mobile/WordPress-iOS/blob/2185a1e1c2cdaa0b089e93ba75b315e058f360ce/Rakefile#L732-L743
Also note that xcodebuild call will likely fail, because "iPhone 6s" is no longer one of the Simulator that ship with Xcode out of the box:
| Fails | |
|---|---|
| :no_entry_sign: |
Please add a type label to this issue. e.g. '[Type] Enhancement' |
Generated by :no_entry_sign: dangerJS