WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Published 20 hours ago • verified publisher icon wordpress-mobile

Adopt `NSPersistentContainer`

Open jkmassel opened this issue 4 years ago • 4 comments
trafficstars

NSPersistentContainer is the recommended way forward for Core Data – we should fully adopt it inside of ContextManager to manage our contexts for us.

jkmassel avatar Feb 08 '21 22:02 jkmassel

Fails
:no_entry_sign: Please add a feature label to this issue. e.g. 'Stats'

Generated by :no_entry_sign: dangerJS

peril-wordpress-mobile[bot] avatar Feb 08 '21 22:02 peril-wordpress-mobile[bot]

This issue has been resolved, hasn't it? Because I see ContextManager is using NSPersistentContainer.

crazytonyli avatar Aug 02 '22 02:08 crazytonyli

NVM, I see there are some details about this in the RFC 😅

crazytonyli avatar Aug 02 '22 04:08 crazytonyli

@jkmassel This adoption seems like quite a big change to me, considering it changes how we fundamentally interact with the database, also the potential complications around how database changes are merged among the main context and derived contexts. IMO, it might be worthwhile to keep the current implementation in the app, alongside the new way of using NSPersistentContainer, so that we can have a switch to use the new approach during development or beta testing and rollback easily if needed. Hopefully, doing this allows us to test the new approach extensively and gives us more confidence in releasing it in production. What do you think?

crazytonyli avatar Aug 17 '22 09:08 crazytonyli