WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Reader: Following Sites list is incomplete

Open eduardozulian opened this issue 4 years ago • 9 comments

Not all the sites you follow in the WordPress.com Reader appear in the app. In fact, the number is way lower and I have the impression that the only sites I see on the Reader are WordPress sites with a connected Jetpack account.

Expected behavior

To see all my followed sites on the Reader, no matter the platform.

Actual behavior

  • I see a smaller number on the app (76) in Reader > Filter > Following if compared to the WordPress.com Reader via browser (200+) [First image]
  • I see a different list of sites on Reader > Manage > Followed Sites. The list has more than 76 sites but it's still incomplete. [Second image]
  • While the sites are not visible in the Following section, their posts are still being listed in the Reader
First Image Second Image
Captura de Tela 2021-01-15 às 12 26 19 Captura de Tela 2021-01-15 às 12 30 07
https://www.atlasobscura.com/ is not on the Following List as well as many other sites Reader > Manage > Followed Sites. The site http://diariodorio.com/ is not present on Reader > Filter > Following

Steps to reproduce the behavior

  1. Log in to WordPress.com
  2. Go to the Reader
  3. Make sure you follow a few non-JP, non-WP sites
  4. Take note of the number of sites you follow
  5. Go to the WP app and click on Reader
  6. Tap the Filter and see the number of sites you're following
  7. From the same page, click on Manage > Followed Sites
  8. Count the number of sites you see

Tasks

  • [x] Get the same list of followed sites in Reader > Following > Filter as in web #17173
  • [ ] Get the same list of followed sites in Reader > Settings > Followed Sites
Tested on iPhone, iOS 14.3, WPiOS 16.4

eduardozulian avatar Jan 15 '21 15:01 eduardozulian

Hey @eduardozulian . The Reader tab filters have been updated to behave as Calypso now does (https://github.com/wordpress-mobile/WordPress-iOS/pull/15585). That is, the filters only show the sites for the tab you are on. Thus the total sites shown in the manage view should be split between all the filterable tabs you have.

I'm going to close this. If you still think there's an issue feel free to reopen.

ScoutHarris avatar Jan 15 '21 18:01 ScoutHarris

Ugh. 🤦 . I just realized what you were saying.

https://www.atlasobscura.com/ is not on the Following List as well as many other sites

Got it. I'll take a look.

ScoutHarris avatar Jan 15 '21 18:01 ScoutHarris

Hey @eduardozulian . Would you mind trying again with WPiOS 16.5? That version is more in sync with Calypso (i.e. the data the API provides).

ScoutHarris avatar Jan 21 '21 19:01 ScoutHarris

No luck, @ScoutHarris

  • My Reader > Filter section now has 55 (when I logged in, the number was 56) sites. It's lower than the initial test with 16.4
  • I still can't see a full list on Manage > Followed Sites

Thanks!

eduardozulian avatar Jan 22 '21 12:01 eduardozulian

I looked into this a little bit. The following list is populated by calling the /read/following/mine endpoint via ReaderTopicServiceRemote.fetchFollowedSitesWithSuccess:failure. Note that no parameters are passed other than meta. Then endpoint returns a maximum of 100 results at a time, ordered from newest. These results are divided between the following, automattic, and followed p2s filters as appropriate. Since the app does not paginate the results from the API, anyone who is follows more than 100 sites will find the excess missing.
We should consider either fetching multiple pages of results until all followed sites are cached or implementing some pagination mechanism. We might need to make a change to the API in order to support alpha numeric ordering.

aerych avatar Feb 05 '21 22:02 aerych

Another report in 3762505-zen.

The sites I follow appear and disappear from my Managed Reader at their own will. If there is a restriction on number of sites which can be displayed on the app it should be my choice and not WPs. Ideally it should be all sites. I follow more than 1700 sites but can only see 100-150 on the app and mostly newly followed sites.

I can confirm they're following 1763 sites now.

reginabally avatar Feb 26 '21 04:02 reginabally

I've added this to the Hummingbird backlog. It'll take a bit of work to figure out and implement a solution, so it's best to treat it as a project.

ScoutHarris avatar Mar 11 '21 18:03 ScoutHarris

Another report in 4042047-zd-woothemes.

while my computer says I follow 163 blogs, my iPad says I follow 95.

reginabally avatar Jun 04 '21 02:06 reginabally

This bug happens because pagination is not implemented for read/following/mine endpoint .

This is an example response:

"page": 1,
"number": 91,
"total_subscriptions": 680

5461497-zd-wootheme

However, fetchFollowedSitesWithSuccess in ReaderTopicService doesn't take into account pagination and "total_subscriptions" value.

The same issue also reproducible on WordPress-Android.

staskus avatar Aug 09 '22 07:08 staskus

Android ticket here: https://github.com/wordpress-mobile/WordPress-Android/issues/20218

daniloercoli avatar Feb 26 '24 11:02 daniloercoli