WordPress-Editor-Android icon indicating copy to clipboard operation
WordPress-Editor-Android copied to clipboard
verified publisher icon wordpress-mobile

Page settings button shows wrong text

Open nbradbury opened this issue 10 years ago • 5 comments

The settings button on LegacyEditorFragment always says "Post Settings" even when the user is editing/creating a page. User reported this problem in WPAndroid here.

8484577e-f266-11e4-9962-c78c6ed280b3

nbradbury avatar Sep 11 '15 12:09 nbradbury

Ref https://github.com/wordpress-mobile/WordPress-Editor-Android/issues/6#issuecomment-125734415

maxme avatar Sep 11 '15 13:09 maxme

We're actually planning on moving the button to the ActionBar anyway:

6-settings-button

(ref further down in that issue: https://github.com/wordpress-mobile/WordPress-Editor-Android/issues/6#issuecomment-135429046)

This is already ready to go but we'll get that into the WPAndroid feature/visual-editor branch after the upcoming WPAndroid PR integrating media support. We're planning on having both of those in for the next demo build (v0.4).

aforcier avatar Sep 11 '15 13:09 aforcier

We're actually planning on moving the button to the ActionBar

I like it!

maxme avatar Sep 11 '15 14:09 maxme

Editor Fragments don't have that information (post / page), the easy fix for the Legacy is to rename it to "Settings" instead of "Post/Page Settings". The better fix is to pass the post/page infomation or the settings title on fragment creation.

maxme avatar Feb 08 '16 09:02 maxme

Another possible fix: could we move the button into the actionbar in the legacy editor, too?

The iOS legacy editor recently got a refresh that moved the button (along with other changes): https://github.com/wordpress-mobile/WordPress-Editor-iOS/pull/801

rachelmcr avatar Apr 29 '16 12:04 rachelmcr