WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Include FluxC `2.99.0` modules with their git history and unit tests

Open wzieba opened this issue 1 year ago • 4 comments

Description

[!TIP] This PR is a result of git filter-repo filtering. To read more about the process, please see internal post: paqN3M-m2-p2. The project discussed there is different, but the same rules apply here.

This PR introduces source code of 3 FluxC modules: fluxc, fluxc-annotations and fluxc-processor in version 2.99.0 into WordPress-Android codebase.

It also includes unit tests that were included in example module, but were technically unit tests of fluxc. To not include example module, I had to alter the git history and modify paths: see the step 1 below.

This PR does not integrate these modules to the build. As you can see below, we only include 3 directories.

image

The attached git-history is extracted from the FluxC repository using git filter-repo. The process contains following phases.

1. Replace unit tests path

Because unit tests in FluxC project were placed in example module, which I didn't want to move, I had to alter the git history and modify paths, effectively moving test directory of example module to fluxc:

git filter-repo \
--path-rename example/src/test:fluxc/src/test \
--force  #needed when filtering after tag checkout 

2. Leave only FluxC modules

In this step, we strip all not needed directories and files, leaving only FluxC ones:

git filter-repo \
--path fluxc-annotations \
--path fluxc-processor \
--path fluxc \
--force  #needed when filtering after tag checkout 

3. Remove Woo-specific unit tests

In unit tests of example module we had a set of Woo-specific unit tests, that required plugin:woocommerce module to run and are not needed in scope of WordPress-Android project. I identified them and removed with:

git filter-repo --path fluxc/src/test/java/org/wordpress/android/fluxc/endpoints/WCWPAPIEndpointTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/model/customer/WCCustomerMapperTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/network/rest/wpcom/jitm/JitmRestClientTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/persistence/CustomerSqlUtilsTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/persistence/mappers/WooPaymentsDepositsOverviewMapperTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/store/CouponStoreTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/store/WCCustomerStoreTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/store/WCInboxStoreTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/store/WCWooPaymentsStoreTest.kt \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/wc/ \
    --path fluxc/src/test/java/org/wordpress/android/fluxc/network/rest/wpcom/wc/ \
    --invert-paths \ # important line: inverts the logic
    --force  #needed when filtering after tag checkout 

Review

There's not much to review in this specific PR. The final result will be possible to review in the integration PR.

You can verify that the last commit in this PR is the same as the commit from 2.99.0 release of FluxC (link). The same in a sense of content/message - hashes will be different as we rewrote history.

wzieba avatar Oct 16 '24 11:10 wzieba

566 Warnings
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning: Class AnnotationConfig is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ActionBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class NoPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JPAPIEndpoint is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WCWPAPIEndpoint is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPAPIEndpoint is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComEndpoint is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComV2Endpoint is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComV3Endpoint is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPOrgAPIEndpoint is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ActionProcessor is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AnnotatedAction is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AnnotatedActionEnum is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CodeGenerationUtils is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EndpointProcessor is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RESTPoet is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FieldSpec is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class XMLRPCPoet is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CommentsAction is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeAction is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EncryptedLogAction is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class VerticalAction is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WhatsNewAction is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorTheme is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlockEditorSettings is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeSupport is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeElement is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeElementListSerializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JWTToken is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackCapability is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PostsModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PublicizeSkipConnection is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ReaderSiteModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RoleModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SubscriptionModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SubscriptionsModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TaxonomyModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TermsModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeCampaignType is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EncryptedSecretStreamKey is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EncryptedLoggingKey is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SecretStreamKey is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class GutenbergLayoutCategoriesModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class GutenbergLayoutCategoryModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class GutenbergLayoutModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PagedListPositionalDataSource is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ImmutablePluginModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FixThreatStatusModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FixStatus is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class InsightTypeDataModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TagModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ViewsModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AcceptHeaderStrategy is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JsonAcceptHeader is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseRequestFuture is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseUploadRequestBody is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CountingSink is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EncryptedLogUploadRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class HTTPAuthModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class MemorizingTrustManager is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class MemorizingHostnameVerifier is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class OkHttpStack is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CookiePathComparator is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RawRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DiscoveryRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DiscoveryUtils is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DiscoveryXMLRPCClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DiscoveryXMLRPCRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RootWPAPIRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Authentication is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ApplicationPasswords is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DiscoveryException is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DiscoveryResultPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPAPIHeadRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class GsonRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JsonObjectOrEmptyArray is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JsonObjectOrEmptyArrayDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JsonObjectOrFalse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JsonObjectOrFalseDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseWPAPIRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPAPIErrorListenerWrapper is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPAPIEncodedBodyRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackWPAPIPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseWPV2MediaRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class MediaWPRESTResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Attribute is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPRestUploadRequestBody is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseWPComRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackTunnelWPAPINetwork is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class OnJetpackTimeoutError is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountBoolResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CloseAccountResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Failure is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountRestPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountPushSettingsResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountPushSocialResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountPushUsernameResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountFetchUsernameSuggestionsResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DomainContactPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FetchAuthOptionsResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class NewAccountResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class IsAvailableResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountSettingsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountSocialRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AccountSocialResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AuthOptionsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DomainContactResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class IsAvailableResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SubscriptionResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SubscriptionRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SubscriptionsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DeliveryMethod is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Notification is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Meta is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class UsernameSuggestionsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CloseAccountRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CloseAccountWPAPIPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SignUpRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SignUpWPAPIPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ActivityTypesDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AuthEmailWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AuthEmailResponsePayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class OauthRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PasswordRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TwoFactorRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BearerRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Token is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TwoFactorResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseWebauthnRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WebauthnRequestParameters is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WebauthnChallengeRequestException is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WebauthnChallengeRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WebauthnTokenRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CampaignStats is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeCampaignObjectiveListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeCampaignObjectiveNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingLocationListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingLocationNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingTopicListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingTopicNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingDeviceListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingDeviceNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingLanguageListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeTargetingLanguageNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeAdSuggestionListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeAdSuggestionNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeAdForecastNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazePaymentMethodsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazePaymentMethodsNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeAddPaymentMethodUrlsNetworkModel is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeCampaignCreationNetworkResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CommentRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class LikeWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class LikesWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PreferredBlogResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PreferredBlogIcon is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class GsonDateAdapter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EncryptedLogRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class UploadEncryptedLogResult is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WpComGeoRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class UsagePeriodDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TierDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAiLogoGeneratorDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FeaturedPostImageDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CostsDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAIAssistantFeatureDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAIAssistantFeatureResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAIQueryResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Choice is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAIRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAIJWTTokenDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ResponseFormat is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAITranscriptionResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAITranscriptionRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAITranscriptionDto is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackAITranscriptionDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class StatsModuleActivatedApiResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackTimeoutRequestHandler is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackTunnelResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class MediaResponseUtils is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class MediaWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class MultipleMediaResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Thumbnails is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RestUploadRequestBody is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class NotificationHashApiResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class NotificationHashesApiResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class NotificationRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class NotificationSeenApiResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RegisterDeviceRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PlansRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PluginJetpackTunnelRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PluginRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PluginWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FetchPluginsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ActionLinks is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class GeoLocation is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PostParent is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PostWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PostData is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PostAutoSave is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class MetaDataAdapter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ReaderRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ReaderSearchSitesDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RevisionsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FixThreatsStatusDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FixableDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RowsDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ThreatContextDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class StatusTypeAdapter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AllDomainsDateAdapter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AutomatedTransferEligibilityCheckResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EligibilityError is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AutomatedTransferStatusResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BooleanTypeAdapter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ConnectSiteInfoResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class DomainSuggestionResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ExportSiteResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class InitiateAutomatedTransferResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class QuickStartCompletedResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SiteEditorsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Options is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Capabilities is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Quota is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Links is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ZendeskSiteMeta is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BloggingPromptsSettings is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class UserRoleWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class UserRolesResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EmailsRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SortField is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EmailsSummaryResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SearchStockMediaResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TermWPComRestResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TermsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackThemeResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackThemeListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ThemeCoroutineRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ThemeDemoDataWPAPIPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComThemeResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComThemeListResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComThemeMobileFriendlyTaxonomy is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComThemeTaxonomies is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPComThemeTier is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PrivacyExtra is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FetchSegmentsResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WhatsNewRestClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WhatsNewResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseWPOrgAPIClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPOrgAPIGsonRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FetchPluginDirectoryResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FetchPluginDirectoryResponseDeserializer is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FetchPluginDirectoryResponseInfo is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PluginWPOrgClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class WPOrgPluginResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BaseXMLRPCClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class XMLRPCException is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class XMLRPCFault is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class NullOutputStream is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CommentXMLRPCClient is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class XmlrpcUploadRequestBody is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SiteXMLRPCResponse is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ActivityLogBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RewindStatusBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class CredentialsBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BackupDownloadStatusBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeElementType is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeSqlUtils is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class EditorThemeElementBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FeatureFlag is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class FeatureFlagValueSourceConverter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class HTTPAuthSqlUtils is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class InsightTypesBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class JetpackCPConnectedSiteEntity is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PostSchedulingReminderBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RemoteConfig is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class RemoteConfigValueConverter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ScanStateBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class StatsRequestBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class StatsBlockBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class StockMediaPageBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class StockMediaBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class ThreatBuilder is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class UpdateAllExceptId is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class BlazeCampaignsDateConverter is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AuthenticationRequestPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AuthenticateTwoFactorPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class AuthEmailPayload is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Danger found 566 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 292.

Generated by :no_entry_sign: Danger

dangermattic avatar Oct 16 '24 11:10 dangermattic

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21304-17a1a83
Commit17a1a8359811bdd1bebd4d8430ea7a51da05784a
Direct Downloadjetpack-prototype-build-pr21304-17a1a83.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Oct 16 '24 12:10 wpmobilebot

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21304-17a1a83
Commit17a1a8359811bdd1bebd4d8430ea7a51da05784a
Direct Downloadwordpress-prototype-build-pr21304-17a1a83.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Oct 16 '24 12:10 wpmobilebot

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Oct 21 '24 13:10 sonarqubecloud[bot]

Review There's not much to review in this specific PR. The final result will be possible to review in the integration PR.

You can verify that the last commit in this PR is the same as the commit from 2.99.0 release of FluxC (link). The same in a sense of content/message - hashes will be different as we rewrote history.

  1. It is very hard to review this change, so I am just going to trust the process here. 😊
  2. I tried compare the history of fluxc, fluxc-annotations and fluxc-processor included in this PR to that on FluxC itself, but again, it was very hard for me to conclude that nothing was missing, lots of moving pieces. As such, and as explained above, I can only trust the process. 🤞
  3. Having said that, I did verify that the last commit in this PR is the same as the commit from 2.99.0. As such, this looks good. 👍

ParaskP7 avatar Oct 22 '24 10:10 ParaskP7