WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Include WordPress-Login-Flow `1.18.0` with its git history

Open wzieba opened this issue 1 year ago • 4 comments

  • [x] Review and merge #21301 first

[!TIP] This PR is a result of git filter-repo filtering. To read more about the process, please see internal post: paqN3M-m2-p2. The project discussed there is different, but the same rules apply here.

Description

This PR is similar to #21260 - it adds the source code of WordPress-Login-Flow in version 1.18.0 with its git history to the WordPress-Android codebase.

image

I've also pushed 1_18_0_filtered_for_vendoring branch to WordPress-Login-Flow repository: https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/tree/1_18_0_filtered_for_vendoring

The filter-repo command was as simple as

git filter-repo --path WordPressLoginFlow

Review

There's not much to review here. You can verify that last commit from this PR is the same as last commit from 1.18.0 release (link) in a sense of content and message. Hashes won't be the same, as the history is rewritten.

wzieba avatar Sep 27 '24 09:09 wzieba

12 Warnings
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning: Class CreatedAccountSource is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class LoginWpcomService is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class LoginState is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class LoginNotification is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class OnCredentialsOK is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TwoFactorRequested is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SiteUtils is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PasskeyRequest is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class PasskeyRequestData is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class SavedState is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

dangermattic avatar Sep 27 '24 09:09 dangermattic

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21266-06504ed
Commit06504ed0ee029dc93fc1fb3e3206e085420e5bfe
Direct Downloadwordpress-prototype-build-pr21266-06504ed.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Sep 27 '24 09:09 wpmobilebot

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21266-06504ed
Commit06504ed0ee029dc93fc1fb3e3206e085420e5bfe
Direct Downloadjetpack-prototype-build-pr21266-06504ed.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Sep 27 '24 09:09 wpmobilebot

Review There's not much to review here. You can verify that last commit from this PR is the same as last commit from 1.18.0 release (link) in a sense of content and message. Hashes won't be the same, as the history is rewritten.

  1. It is very hard to review this change, so I am just going to trust the process here. 😊
  2. I tried compare the history of login included in this PR to that on Login itself, but again, it was very hard for me to conclude that nothing was missing, lots of moving pieces. As such, and as explained above, I can only trust the process. 🤞
  3. Having said that, I did verify that the last commit in this PR is the same as the commit from 1.18.0. As such, this looks good. 👍

PS: There are these 2 top commits (Bump fluxc to trunk + Attempt to fix build issue), but those aren't WordPressLoginFlow related and as such can be ignored.

ParaskP7 avatar Oct 22 '24 10:10 ParaskP7