WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

No visual indicator to separate different days' notifications

Open ScenarioKG opened this issue 1 year ago • 14 comments

Expected behavior

Notifications should clearly display separation between different days for better readability.

Actual behavior

Notifications from different days appear without clear separators, potentially confusing users about the timeline of events.

Steps to reproduce the behavior

  1. Open 'Notifications'
  2. Navigate to notifications older than a few days.
Tested on [device], Android [version], JPAndroid / WPAndroid [version]

Galaxy S21 5G, Android 12, Jetpack 25.2.1 (1444)/WordPress 25.2.1 (1444)

SCREENSHOT_1

ScenarioKG avatar Aug 30 '24 13:08 ScenarioKG

Thanks for reporting! 👍

dangermattic avatar Aug 30 '24 13:08 dangermattic

Hi , can you guide me a little like which file handle's this , I am new

aaishwarymishra avatar Oct 09 '24 17:10 aaishwarymishra

@BLANKatGITHUB I think ui.notifications.adapters.NotesAdapter is what you're looking for.

nbradbury avatar Oct 10 '24 13:10 nbradbury

Hi! Anyone working on it Or not? If not, I want to work on the issue as I think I got the issue pretty well.

Anubhav8176 avatar Dec 29 '24 16:12 Anubhav8176

@Anubhav8176 Apologies for the delay - I took some time off recently. Yes, please feel free to work on this. Thank you!

nbradbury avatar Jan 03 '25 16:01 nbradbury

@nbradbury Can you please guide me to which file/folder should I look for the issue? As I am very new to the open source community

Anubhav8176 avatar Jan 12 '25 11:01 Anubhav8176

Can you please guide me to which file/folder should I look for the issue?

As mentioned above, I think ui.notifications.adapters.NotesAdapter is what you're looking for.

nbradbury avatar Jan 13 '25 13:01 nbradbury

@nbradbury I made few changes in the code in buildFilteredNotesList function and now i want to test that the changes are reflected or not in the app. Where I can check the notification options in the app. I have tried running app on emulator but couldn't get to the notification screen. Can you help me with this?

Anubhav8176 avatar Jan 15 '25 07:01 Anubhav8176

@Anubhav8176 Make sure you're using a Jetpack build variant rather than a WordPress one, since notifications are only available in the Jetpack app.

Image

nbradbury avatar Jan 15 '25 13:01 nbradbury

@nbradbury
Do I need to install jetpack to see the notification, and even when I try to click on install jetpack it asks the email and password when i enter it just shows unknown client_id. I also tried to go through the documentation and couldn't find any satisfying answer to this problem.

Image

Anubhav8176 avatar Jan 15 '25 18:01 Anubhav8176

@Anubhav8176 Yes, you do need to have the Jetpack app installed to see notifications, and your site must also be using the Jetpack plugin. Are you using the Jetpack plugin?

nbradbury avatar Jan 16 '25 13:01 nbradbury

Yes I have created a test site using jurassic.ninja (mentioned in README.md) and when i see the installed plugins it mentioned jetpack is installed.

Image

Anubhav8176 avatar Jan 16 '25 14:01 Anubhav8176

@Anubhav8176 Okay, so the problem, then, is that you're seeing "unknown client_id" when attempting to login? I'll check with our team about this.

nbradbury avatar Jan 16 '25 15:01 nbradbury

@Anubhav8176 I checked with the team and unfortunately the problem is that our documentation is incomplete, in that it's missing instructions for Jetpack builds. We'll resolve this but it's unlikely to happen soon. For that reason, if you still wish to contribute, I recommend choosing something that's not Jetpack-specific.

nbradbury avatar Jan 17 '25 12:01 nbradbury