WordPress-Android
WordPress-Android copied to clipboard
[Reader] Implement tags feed card actions (part 3)
Fixes #20670
- Fix tags menu item label: "Tags" -> "Your Tags".
- Implements tags feed overflow menu UI and all actions.
- Fix "More from
<tag>
" button action: it should open the tag post list instead of filtering the tags feed. - Implements empty state button action (no tags followed).
To Test:
- Install JP and sign in.
- Enable
reader_tags_feed
feature flag and restart the app. - Open reader.
Fix tags menu item label
- Open the dropdown menu.
- π Verify the tags feed item label is "Your Tags" instead of "Tags".
Overflow menu
- Tap the tags feed item with at least one tag followed.
- π Tap the overflow menu in any post card: the items should be shown as expected. You should be able to dismiss the menu and all the actions should be working as expected (the same way they work in the other feeds).
Fix "More from <tag>
" button action
- π Scroll to the end of the tags horizontal list and tap the "More from
<tag>
" button: it should open the tag post list screen instead of applying the tag filter in the tags feed. Tapping the tag header should still apply the tag filter in the current feed.
Empty state button action
- Unsubscribe from all your tags.
- π Verify the tags feed: you should see the empty state UI.
- π Tap the "Get Started" button: you should see the "Choose your interests" screen.
- π Select any tags and tap "Done": the tags should be seen loaded in the tags feed.
- π Verify the tags are shown in other contexts (e.g. in the "Manage Tags & Blogs" screen, in the tags feed after restarting the app).
Regression Notes
-
Potential unintended areas of impact
- None
-
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing and updated unit tests
-
What automated tests I added (or what prevented me from doing so)
- Updated
ReaderTagsFeedViewModelTest.kt
.
- Updated
PR Submission Checklist:
- [x] I have completed the Regression Notes.
- [x] I have considered adding accessibility improvements for my changes.
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.
Testing Checklist (strike-out the not-applying and unnecessary ones):
- [ ] WordPress.com sites and self-hosted Jetpack sites.
- [ ] Portrait and landscape orientations.
- [ ] Light and dark modes.
- [ ] Fonts: Larger, smaller and bold text.
- [ ] High contrast.
- [ ] Talkback.
- [ ] Languages with large words or with letters/accents not frequently used in English.
- [ ] Right-to-left languages. (Even if translation isnβt complete, formatting should still respect the right-to-left layout)
- [ ] Large and small screen sizes. (Tablet and smaller phones)
- [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)
2 Warnings | |
---|---|
:warning: | strings.xml files should only be updated on release branches, when the translations are downloaded by our automation. |
:warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
Generated by :no_entry_sign: Danger
π² You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20801-3b0e0ae | |
Commit | 3b0e0ae62486ceb82ea13c9dad9aadaee7072c39 | |
Direct Download | wordpress-prototype-build-pr20801-3b0e0ae.apk |
π² You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20801-3b0e0ae | |
Commit | 3b0e0ae62486ceb82ea13c9dad9aadaee7072c39 | |
Direct Download | jetpack-prototype-build-pr20801-3b0e0ae.apk |
Codecov Report
Attention: Patch coverage is 45.12195%
with 45 lines
in your changes are missing coverage. Please review.
Project coverage is 40.79%. Comparing base (
03d53da
) to head (3b0e0ae
). Report is 2 commits behind head on feature/tags-ia.
Additional details and impacted files
@@ Coverage Diff @@
## feature/tags-ia #20801 +/- ##
===================================================
- Coverage 40.79% 40.79% -0.01%
===================================================
Files 1493 1493
Lines 68642 68705 +63
Branches 11337 11339 +2
===================================================
+ Hits 28003 28027 +24
- Misses 38095 38134 +39
Partials 2544 2544
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
π Scroll to the end of the tags horizontal list and tap the "More from
" button: it should open the tag post list screen instead of applying the tag filter in the tags feed.
This works as expected, although I found that after unsubscribing from a tag and returning to the Your Tags screen, the tag still appears in the list.
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@daniloercoli thanks for the review and for catching this bug. I've implemented a workaround to fix it. This is not the best solution since it updates the whole tags list after navigating back to Tags feed, but for a number of reasons I wasn't able to implement the ideal solution so far, which involves removing from UI the tags that were unsubscribed and adding the ones that were subscribed to instead of refreshing the whole list (thanks for the help @thomashorta ).
If the current workaround fixes the problem you've found, I propose that we implement the ideal solution in another PR so we can merge the actions ASAP allowing us to better test the project. WDYT?