Stories removal

[jarvislin]

See: p1706056464986299/1705928714.429819-slack-C0436E5L5V1

This is a follow-up PR for https://github.com/wordpress-mobile/WordPress-Android/pull/20014 which removes Stories from the codebase.

---

To Test:

---

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual

3. What automated tests I added (or what prevented me from doing so)

   • None

---

PR Submission Checklist:

• [ ] I have completed the Regression Notes.
• [ ] I have considered adding accessibility improvements for my changes.
• [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

UI Changes Testing Checklist:

• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] Talkback.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] Large and small screen sizes. (Tablet and smaller phones)
• [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[dangermattic]

	4 Warnings
:warning:	strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning:	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	This PR is assigned to the milestone 24.4. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20016-0bd3e14
	Commit	0bd3e146fb572705f24823dc1556c6790e318556
	Direct Download	wordpress-prototype-build-pr20016-0bd3e14.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20016-0bd3e14
	Commit	0bd3e146fb572705f24823dc1556c6790e318556
	Direct Download	jetpack-prototype-build-pr20016-0bd3e14.apk

Note: Google Login is not supported on these builds.

[peril-wordpress-mobile[bot]]

	Warnings
:warning:	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by :no_entry_sign: dangerJS

[wpmobilebot]

Found 1 violations:

The PR caused some dependency changes (expand to see details)

++--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2
+|    +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (*)
+|    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
+|    +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
+|    \--- androidx.lifecycle:lifecycle-common-java8:2.6.2 (c)
++--- androidx.camera:camera-camera2:1.2.3
+|    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    +--- androidx.camera:camera-core:1.2.3
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
+|    |    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+|    |    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+|    |    +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.6 (*)
+|    |    +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.6.2 (*)
+|    |    +--- com.google.auto.value:auto-value-annotations:1.6.3
+|    |    +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.20 (*)
+|    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+|    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+|    +--- com.google.auto.value:auto-value-annotations:1.6.3
+|    \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-+--- com.automattic:stories:2.4.0
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.9.10 (*)
-|    +--- androidx.databinding:viewbinding:8.1.0 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc
-|    |    \--- org.jetbrains.kotlinx:kotlinx-serialization-runtime-jvm:1.0-M1-1.4.0-rc
-|    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.9.20 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.9.20 (*)
-|    +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.20 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-|    +--- androidx.constraintlayout:constraintlayout:1.1.3 -> 2.1.4 (*)
-|    +--- androidx.core:core-ktx:1.2.0 -> 1.12.0 (*)
-|    +--- androidx.emoji:emoji:1.0.0
-|    |    \--- androidx.core:core:1.0.0 -> 1.12.0 (*)
-|    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-|    +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-|    +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-|    +--- jp.wasabeef:glide-transformations:4.3.0
-|    |    \--- com.github.bumptech.glide:glide:4.11.0 -> 4.16.0 (*)
-|    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    +--- com.automattic.stories:photoeditor:2.4.0
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc (*)
-|    |    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-|    |    +--- androidx.core:core-ktx:1.2.0 -> 1.12.0 (*)
-|    |    +--- androidx.camera:camera-core:1.0.0-alpha06 -> 1.2.3
-|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
-|    |    |    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-|    |    |    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-|    |    |    +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.6 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.6.2 (*)
-|    |    |    +--- com.google.auto.value:auto-value-annotations:1.6.3
-|    |    |    +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.20 (*)
-|    |    +--- androidx.camera:camera-camera2:1.0.0-alpha06 -> 1.2.3
-|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |    |    +--- androidx.camera:camera-core:1.2.3 (*)
-|    |    |    +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-|    |    |    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-|    |    |    +--- com.google.auto.value:auto-value-annotations:1.6.3
-|    |    |    \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-|    |    +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-|    |    +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-|    |    +--- jp.wasabeef:glide-transformations:4.3.0 (*)
-|    |    +--- com.github.chrisbanes:PhotoView:2.3.0
-|    |    |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
-|    |    +--- com.automattic.stories:mp4compose:2.4.0
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-|    |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-|    |    \--- androidx.emoji:emoji:1.0.0 (*)
-|    +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.6.2 (*)
-|    +--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.6.2
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
-|    |    +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-common-java8:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
-|    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-|    \--- com.github.chrisbanes:PhotoView:2.3.0 (*)
-+--- com.automattic.stories:mp4compose:2.4.0 (*)
-+--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2 (*)
-+--- androidx.camera:camera-camera2:1.2.3 (*)
-\--- com.github.chrisbanes:PhotoView:2.3.0 (*)
+\--- com.github.chrisbanes:PhotoView:2.3.0
+     \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)

Please review and act accordingly

<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>

<ACCUMULATED-VIOLATIONS>

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 40.39%. Comparing base (50f27a4) to head (0bd3e14).

Files	Patch %	Lines
...ress/android/ui/photopicker/MediaPickerLauncher.kt	0.00%	4 Missing :warning:
...ess/android/ui/photopicker/PhotoPickerViewModel.kt	25.00%	3 Missing :warning:
...java/org/wordpress/android/ui/posts/PostUtils.java	0.00%	3 Missing :warning:
...ordpress/android/ui/uploads/PostUploadHandler.java	0.00%	2 Missing :warning:
...ess/android/ui/mediapicker/MediaPickerViewModel.kt	0.00%	0 Missing and 1 partial :warning:
...g/wordpress/android/ui/mysite/menu/MenuActivity.kt	0.00%	1 Missing :warning:
...rdpress/android/ui/uploads/MediaUploadHandler.java	0.00%	1 Missing :warning:
.../android/ui/uploads/MediaUploadReadyProcessor.java	0.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #20016      +/-   ##
==========================================
+ Coverage   40.17%   40.39%   +0.21%     
==========================================
  Files        1476     1459      -17     
  Lines       68248    67161    -1087     
  Branches    11331    11146     -185     
==========================================
- Hits        27418    27129     -289     
+ Misses      38320    37550     -770     
+ Partials     2510     2482      -28     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[antonis]

Thank you for cleaning up the code @jarvislin 🙇 I did a 1st pass of the PR today and the code changes look consistent to me. I also didn't encounter any errors or inconsistencies while testing. I opened a PR with some additional suggestions for removals at https://github.com/wordpress-mobile/WordPress-Android/pull/20341 feel free to merge on top of your PR if you agree with the changes. I plan to take a 2nd pass tomorrow or Monday since the changes are extensive and I might have missed something.

[jarvislin]

@antonis Thank you so much for reviewing this PR. I've update the missing icons and reverted all changes to strings except for the main strings resource.

[jarvislin]

Awesome work @jarvislin 🏅 The code changes look consistent to me and the app behaved as expected in my tests. I've tested both the Jetpack app and the WordPress app for any side effects and didn't notice any issues. It feels great cleaning up the code (6.3K loc 😮) along with the feature :)

I am so happy for this. I've finally completed my onboarding project 🥹 Thanks again!