WordPress-Android
WordPress-Android copied to clipboard
Remove editor_upload_media_paused analytics event
Removes instances of the (unreleased) editor_upload_media_paused
analytics event in favor of tracking these as part of media_service_upload_response_error
in tandem with CONNECTION_ERROR
.
See also:
- https://github.com/wordpress-mobile/WordPress-Android/pull/19890
To Test:
editor_upload_media_paused
should no longer appear in analytics events.
Regression Notes
-
Potential unintended areas of impact Analytics events
-
What I did to test those areas of impact (or what existing automated tests I relied on) Manual Testing in Superset/Looker
-
What automated tests I added (or what prevented me from doing so) N/A
PR Submission Checklist:
- [ ] I have completed the Regression Notes.
- [ ] I have considered adding accessibility improvements for my changes.
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr19972-61034fc | |
Commit | 61034fc9071a8bd50040a6eadae4c6e7aa1197c7 | |
Direct Download | wordpress-prototype-build-pr19972-61034fc.apk |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr19972-61034fc | |
Commit | 61034fc9071a8bd50040a6eadae4c6e7aa1197c7 | |
Direct Download | jetpack-prototype-build-pr19972-61034fc.apk |
Codecov Report
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
916c1cc
) 40.45% compared to head (61034fc
) 40.45%. Report is 973 commits behind head on trunk.
Files | Patch % | Lines |
---|---|---|
...press/android/ui/posts/editor/media/EditorMedia.kt | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## trunk #19972 +/- ##
=======================================
Coverage 40.45% 40.45%
=======================================
Files 1440 1440
Lines 66513 66506 -7
Branches 10957 10957
=======================================
Hits 26905 26905
+ Misses 37121 37114 -7
Partials 2487 2487
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Deferring to 24.2 milestone to evaluate this event further.
It seems this PR was approved a while back, but it's not being merged until further evaluation. Instead of pushing the milestone every release, I am going to remove the milestone from it. Please do set it once it's decided which release it's going to go in.